mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-04 04:33:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add comments, close Statement

Browse source
This commit is contained in:
Till Faelligen 2022-04-26 10:23:04 +02:00
parent c1a4dd7c66
commit 0175dedcfc
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
syncapi/storage/sqlite3/memberships_table.go
View file

@ -70,7 +70,7 @@ type membershipsStatements struct {
db *sql.DB db *sql.DB
upsertMembershipStmt *sql.Stmt upsertMembershipStmt *sql.Stmt
selectMembershipCountStmt *sql.Stmt selectMembershipCountStmt *sql.Stmt
selectHeroesStmt *sql.Stmt //selectHeroesStmt *sql.Stmt - prepared at runtime due to variadic
} }
func NewSqliteMembershipsTable(db *sql.DB) (tables.Memberships, error) { func NewSqliteMembershipsTable(db *sql.DB) (tables.Memberships, error) {
@ -84,7 +84,7 @@ func NewSqliteMembershipsTable(db *sql.DB) (tables.Memberships, error) {
return s, sqlutil.StatementList{ return s, sqlutil.StatementList{
{&s.upsertMembershipStmt, upsertMembershipSQL}, {&s.upsertMembershipStmt, upsertMembershipSQL},
{&s.selectMembershipCountStmt, selectMembershipCountSQL}, {&s.selectMembershipCountStmt, selectMembershipCountSQL},
{&s.selectHeroesStmt, selectHeroesSQL}, // {&s.selectHeroesStmt, selectHeroesSQL}, - prepared at runtime due to variadic
}.Prepare(db) }.Prepare(db)
} }
@ -120,10 +120,11 @@ func (s *membershipsStatements) SelectHeroes(
ctx context.Context, txn *sql.Tx, roomID, userID string, memberships []string, ctx context.Context, txn *sql.Tx, roomID, userID string, memberships []string,
) (heroes []string, err error) { ) (heroes []string, err error) {
stmtSQL := strings.Replace(selectHeroesSQL, "($3)", sqlutil.QueryVariadicOffset(len(memberships), 2), 1) stmtSQL := strings.Replace(selectHeroesSQL, "($3)", sqlutil.QueryVariadicOffset(len(memberships), 2), 1)
stmt, err := s.db.Prepare(stmtSQL) stmt, err := s.db.PrepareContext(ctx, stmtSQL)
if err != nil { if err != nil {
return return
} }
defer internal.CloseAndLogIfError(ctx, stmt, "SelectHeroes: stmt.close() failed")
params := []interface{}{ params := []interface{}{
roomID, userID, roomID, userID,
} }