mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-16 18:43:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Repeatable reads for /sync

Browse source
This commit is contained in:
Neil Alexander 2022-10-10 14:01:13 +01:00
parent 0f09e9d196
commit 0dfd3cd876
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
1 changed files with 17 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
syncapi/storage/shared/storage_consumer.go
View file

@ -56,13 +56,6 @@ type Database struct {
} }
func (d *Database) NewDatabaseSnapshot(ctx context.Context) (*DatabaseTransaction, error) { func (d *Database) NewDatabaseSnapshot(ctx context.Context) (*DatabaseTransaction, error) {
return d.NewDatabaseTransaction(ctx)
/*
TODO: Repeatable read is probably the right thing to do here,
but it seems to cause some problems with the invite tests, so
need to investigate that further.
txn, err := d.DB.BeginTx(ctx, &sql.TxOptions{ txn, err := d.DB.BeginTx(ctx, &sql.TxOptions{
// Set the isolation level so that we see a snapshot of the database. // Set the isolation level so that we see a snapshot of the database.
// In PostgreSQL repeatable read transactions will see a snapshot taken // In PostgreSQL repeatable read transactions will see a snapshot taken
@ -80,7 +73,6 @@ func (d *Database) NewDatabaseSnapshot(ctx context.Context) (*DatabaseTransactio
ctx: ctx, ctx: ctx,
txn: txn, txn: txn,
}, nil }, nil
*/
} }
func (d *Database) NewDatabaseTransaction(ctx context.Context) (*DatabaseTransaction, error) { func (d *Database) NewDatabaseTransaction(ctx context.Context) (*DatabaseTransaction, error) {