From 0f01780282fd8153b23e31339fd8f518ed2ffb10 Mon Sep 17 00:00:00 2001
From: Neil Alexander <neilalexander@users.noreply.github.com>
Date: Wed, 3 Aug 2022 17:14:57 +0100
Subject: [PATCH] Revert "Maybe fix concurrent map write"

This reverts commit da0dbb836207a911afe77e6f6d63c4809669693c.
---
 keyserver/internal/internal.go | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/keyserver/internal/internal.go b/keyserver/internal/internal.go
index 5140911f7..c146b2aa0 100644
--- a/keyserver/internal/internal.go
+++ b/keyserver/internal/internal.go
@@ -430,28 +430,23 @@ func (a *KeyInternalAPI) queryRemoteKeys(
 
 	for result := range resultCh {
 		for userID, nest := range result.DeviceKeys {
-			respMu.Lock()
 			res.DeviceKeys[userID] = make(map[string]json.RawMessage)
-			respMu.Unlock()
 			for deviceID, deviceKey := range nest {
 				keyJSON, err := json.Marshal(deviceKey)
 				if err != nil {
 					continue
 				}
-				respMu.Lock()
 				res.DeviceKeys[userID][deviceID] = keyJSON
-				respMu.Unlock()
 			}
 		}
 
-		respMu.Lock()
 		for userID, body := range result.MasterKeys {
 			res.MasterKeys[userID] = body
 		}
+
 		for userID, body := range result.SelfSigningKeys {
 			res.SelfSigningKeys[userID] = body
 		}
-		respMu.Unlock()
 
 		// TODO: do we want to persist these somewhere now
 		// that we have fetched them?
@@ -525,10 +520,7 @@ func (a *KeyInternalAPI) queryRemoteKeysOnServer(
 		resultCh <- &queryKeysResp
 		return
 	}
-
 	respMu.Lock()
-	defer respMu.Unlock()
-
 	res.Failures[serverName] = map[string]interface{}{
 		"message": err.Error(),
 	}
@@ -545,6 +537,8 @@ func (a *KeyInternalAPI) queryRemoteKeysOnServer(
 	if len(res.DeviceKeys) > 0 {
 		delete(res.Failures, serverName)
 	}
+	respMu.Unlock()
+
 }
 
 func (a *KeyInternalAPI) populateResponseWithDeviceKeysFromDatabase(