More tweaks

This commit is contained in:
Neil Alexander 2020-09-29 12:25:05 +01:00
parent b8f595b09d
commit 0fc1029874
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
2 changed files with 6 additions and 5 deletions

View file

@ -17,6 +17,7 @@ package routing
import ( import (
"context" "context"
"encoding/json" "encoding/json"
"errors"
"fmt" "fmt"
"net/http" "net/http"
"sync" "sync"
@ -206,10 +207,10 @@ func (t *txnReq) processTransaction(ctx context.Context) (*gomatrixserverlib.Res
return nil, &jsonErr return nil, &jsonErr
} else { } else {
// Auth errors mean the event is 'rejected' which have to be silent to appease sytest // Auth errors mean the event is 'rejected' which have to be silent to appease sytest
_, rejected := err.(*gomatrixserverlib.NotAllowed) errMsg := ""
errMsg := err.Error() rejected := errors.Is(err, &gomatrixserverlib.NotAllowed{})
if rejected { if !rejected {
errMsg = "" errMsg = err.Error()
} }
util.GetLogger(ctx).WithError(err).WithField("event_id", e.EventID()).WithField("rejected", rejected).Warn( util.GetLogger(ctx).WithError(err).WithField("event_id", e.EventID()).WithField("rejected", rejected).Warn(
"Failed to process incoming federation event, skipping", "Failed to process incoming federation event, skipping",

View file

@ -133,7 +133,7 @@ func (r *Inputer) processRoomEvent(
"soft_fail": softfail, "soft_fail": softfail,
"sender": event.Sender(), "sender": event.Sender(),
}).Debug("Stored rejected event") }).Debug("Stored rejected event")
return event.EventID(), nil return event.EventID(), rejectionErr
} }
if input.Kind == api.KindRewrite { if input.Kind == api.KindRewrite {