mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-21 04:53:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add TODO, add comment/make more obvious what's happening

Browse source
This commit is contained in:
Till Faelligen 2022-12-02 15:16:24 +01:00
parent bbfdeb03e7
commit 28077cde30
No known key found for this signature in database
GPG key ID: ACCDC9606D472758
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
appservice/appservice_test.go
View file

@ -39,8 +39,8 @@ func TestAppserviceInternalAPI(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch { switch {
case strings.Contains(r.URL.Path, "location"): case strings.Contains(r.URL.Path, "location"):
// Check if we've got an existing protocol, if so, return a proper response.
if r.URL.Path[len(r.URL.Path)-3:] == existingProtocol { if r.URL.Path[len(r.URL.Path)-len(existingProtocol):] == existingProtocol {
if err := json.NewEncoder(w).Encode(wantLocationResponse); err != nil { if err := json.NewEncoder(w).Encode(wantLocationResponse); err != nil {
t.Fatalf("failed to encode response: %s", err) t.Fatalf("failed to encode response: %s", err)
} }
@ -51,7 +51,7 @@ func TestAppserviceInternalAPI(t *testing.T) {
} }
return return
case strings.Contains(r.URL.Path, "user"): case strings.Contains(r.URL.Path, "user"):
if r.URL.Path[len(r.URL.Path)-3:] == existingProtocol { if r.URL.Path[len(r.URL.Path)-len(existingProtocol):] == existingProtocol {
if err := json.NewEncoder(w).Encode(wantUserResponse); err != nil { if err := json.NewEncoder(w).Encode(wantUserResponse); err != nil {
t.Fatalf("failed to encode response: %s", err) t.Fatalf("failed to encode response: %s", err)
} }
@ -62,7 +62,7 @@ func TestAppserviceInternalAPI(t *testing.T) {
} }
return return
case strings.Contains(r.URL.Path, "protocol"): case strings.Contains(r.URL.Path, "protocol"):
if r.URL.Path[len(r.URL.Path)-3:] == existingProtocol { if r.URL.Path[len(r.URL.Path)-len(existingProtocol):] == existingProtocol {
if err := json.NewEncoder(w).Encode(wantProtocolResponse); err != nil { if err := json.NewEncoder(w).Encode(wantProtocolResponse); err != nil {
t.Fatalf("failed to encode response: %s", err) t.Fatalf("failed to encode response: %s", err)
} }
@ -77,6 +77,7 @@ func TestAppserviceInternalAPI(t *testing.T) {
} }
})) }))
// TODO: use test.WithAllDatabases
// only one DBType, since appservice.AddInternalRoutes complains about multiple prometheus counters added // only one DBType, since appservice.AddInternalRoutes complains about multiple prometheus counters added
base, closeBase := testrig.CreateBaseDendrite(t, test.DBTypeSQLite) base, closeBase := testrig.CreateBaseDendrite(t, test.DBTypeSQLite)
defer closeBase() defer closeBase()