From 322a8f471c33de124400f425d9dea9ce5922c3be Mon Sep 17 00:00:00 2001
From: SUMUKHA-PK <sumukhapk46@gmail.com>
Date: Fri, 2 Aug 2019 15:55:31 +0530
Subject: [PATCH] Suggested changes made

---
 clientapi/routing/room_tagging.go | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/clientapi/routing/room_tagging.go b/clientapi/routing/room_tagging.go
index 2ae810593..42b0b0c63 100644
--- a/clientapi/routing/room_tagging.go
+++ b/clientapi/routing/room_tagging.go
@@ -115,6 +115,8 @@ func PutTag(
 		return httputil.LogThenError(req, err)
 	}
 
+	// Send data to syncProducer in order to inform clients of changes
+	// Run in a goroutine in order to prevent blocking the tag request response
 	go func() {
 		if err := syncProducer.SendData(userID, roomID, "m.tag"); err != nil {
 			logrus.WithError(err).Error("Failed to send m.tag account data update to syncapi")
@@ -181,6 +183,8 @@ func DeleteTag(
 		return httputil.LogThenError(req, err)
 	}
 
+	// Send data to syncProducer in order to inform clients of changes
+	// Run in a goroutine in order to prevent blocking the tag request response
 	go func() {
 		if err := syncProducer.SendData(userID, roomID, "m.tag"); err != nil {
 			logrus.WithError(err).Error("Failed to send m.tag account data update to syncapi")
@@ -193,7 +197,8 @@ func DeleteTag(
 	}
 }
 
-// obtainSavedTags gets all the tags saved in the DB
+// obtainSavedTags gets all tags scoped to a userID and roomID
+// from the database
 func obtainSavedTags(
 	req *http.Request,
 	userID string,
@@ -208,14 +213,11 @@ func obtainSavedTags(
 	data, err := accountDB.GetAccountDataByType(
 		req.Context(), localpart, roomID, "m.tag",
 	)
-	if err != nil {
-		return "", nil, err
-	}
 
-	return localpart, data, nil
+	return localpart, data, err
 }
 
-// saveTagData saves the tag data into the DB
+// saveTagData saves the provided tag data into the database
 func saveTagData(
 	req *http.Request,
 	localpart string,