mirror of
https://github.com/matrix-org/dendrite.git
synced 2025-12-29 01:33:10 -06:00
Review comments @Kegsay
This commit is contained in:
parent
60f43e37c2
commit
33b3b07b39
|
|
@ -209,6 +209,7 @@ func createRoom(
|
||||||
createContent := map[string]interface{}{}
|
createContent := map[string]interface{}{}
|
||||||
if len(r.CreationContent) > 0 {
|
if len(r.CreationContent) > 0 {
|
||||||
if err = json.Unmarshal(r.CreationContent, &createContent); err != nil {
|
if err = json.Unmarshal(r.CreationContent, &createContent); err != nil {
|
||||||
|
util.GetLogger(req.Context()).WithError(err).Error("json.Unmarshal for creation_content failed")
|
||||||
return util.JSONResponse{
|
return util.JSONResponse{
|
||||||
Code: http.StatusBadRequest,
|
Code: http.StatusBadRequest,
|
||||||
JSON: jsonerror.BadJSON("invalid create content"),
|
JSON: jsonerror.BadJSON("invalid create content"),
|
||||||
|
|
@ -229,6 +230,7 @@ func createRoom(
|
||||||
// Merge powerLevelContentOverride fields by unmarshalling it atop the defaults
|
// Merge powerLevelContentOverride fields by unmarshalling it atop the defaults
|
||||||
err = json.Unmarshal(r.PowerLevelContentOverride, &powerLevelContent)
|
err = json.Unmarshal(r.PowerLevelContentOverride, &powerLevelContent)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
util.GetLogger(req.Context()).WithError(err).Error("json.Unmarshal for power_level_content_override failed")
|
||||||
return util.JSONResponse{
|
return util.JSONResponse{
|
||||||
Code: http.StatusBadRequest,
|
Code: http.StatusBadRequest,
|
||||||
JSON: jsonerror.BadJSON("malformed power_level_content_override"),
|
JSON: jsonerror.BadJSON("malformed power_level_content_override"),
|
||||||
|
|
@ -336,6 +338,11 @@ func createRoom(
|
||||||
|
|
||||||
var initialStateEvents []fledglingEvent
|
var initialStateEvents []fledglingEvent
|
||||||
for i := range r.InitialState {
|
for i := range r.InitialState {
|
||||||
|
if r.InitialState[i].StateKey != "" {
|
||||||
|
initialStateEvents = append(initialStateEvents, r.InitialState[i])
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
switch r.InitialState[i].Type {
|
switch r.InitialState[i].Type {
|
||||||
case gomatrixserverlib.MRoomCreate:
|
case gomatrixserverlib.MRoomCreate:
|
||||||
continue
|
continue
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue