From 41cf902d094f5d7477e075eb72ce83d0ac85a66b Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Mon, 10 Jul 2023 15:52:27 +0200
Subject: [PATCH] Avoid unnecessary loop

---
 syncapi/routing/messages.go | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/syncapi/routing/messages.go b/syncapi/routing/messages.go
index 7d700a191..7d44b57ec 100644
--- a/syncapi/routing/messages.go
+++ b/syncapi/routing/messages.go
@@ -567,15 +567,17 @@ func (r *messagesReq) backfill(roomID string, backwardsExtremities map[string][]
 	if res.HistoryVisibility == "" {
 		res.HistoryVisibility = gomatrixserverlib.HistoryVisibilityShared
 	}
-	for i := range res.Events {
+	events := res.Events
+	for i := range events {
+		events[i].Visibility = res.HistoryVisibility
 		_, err = r.db.WriteEvent(
 			context.Background(),
-			res.Events[i],
+			events[i],
 			[]*rstypes.HeaderedEvent{},
 			[]string{},
 			[]string{},
 			nil, true,
-			res.HistoryVisibility,
+			events[i].Visibility,
 		)
 		if err != nil {
 			return nil, err
@@ -583,14 +585,10 @@ func (r *messagesReq) backfill(roomID string, backwardsExtremities map[string][]
 	}
 
 	// we may have got more than the requested limit so resize now
-	events := res.Events
 	if len(events) > limit {
 		// last `limit` events
 		events = events[len(events)-limit:]
 	}
-	for _, ev := range events {
-		ev.Visibility = res.HistoryVisibility
-	}
 
 	return events, nil
 }