From 4ac7f10af8a8c051ca34e3140a8a178eb0ce818f Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Tue, 14 Nov 2017 19:48:49 +0000 Subject: [PATCH] Disable gotype linter gotype does not seem to play nicely with the gb vendor directory. In particular, it wants each of our dependencies to be built and installed (see https://github.com/golang/go/issues/10969), but (empirically) it will not accept them being installed in `pkg` but insists on them being in `vendor/pkg`. This presents a problem because `gb build` builds the packages into `pkg` (which doesn't seem entirely unreasonable since `.` comes before `vendor` in `$GOPATH`). `go install github.com/x/y` does install in `vendor/pkg` but requires us to know the name of each package. The general conclusion of https://github.com/alecthomas/gometalinter/issues/91 seems to have been that the easiest thing to do is to disable `gotype` for now. --- linter-fast.json | 1 - linter.json | 1 - 2 files changed, 2 deletions(-) diff --git a/linter-fast.json b/linter-fast.json index 3825fa615..aa86054e8 100644 --- a/linter-fast.json +++ b/linter-fast.json @@ -4,7 +4,6 @@ "Deadline": "5m", "Enable": [ "vetshadow", - "gotype", "deadcode", "gocyclo", "ineffassign", diff --git a/linter.json b/linter.json index 7305539d0..511c244b6 100644 --- a/linter.json +++ b/linter.json @@ -4,7 +4,6 @@ "Deadline": "5m", "Enable": [ "vetshadow", - "gotype", "deadcode", "gocyclo", "golint",