From 4c25a36e8a645f0db9cd832d13af90743786728b Mon Sep 17 00:00:00 2001 From: Neil Alexander Date: Thu, 17 Feb 2022 17:38:02 +0000 Subject: [PATCH] Don't proactively cache event types and state keys when we don't know if the transaction has persisted yet --- roomserver/storage/shared/storage.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/roomserver/storage/shared/storage.go b/roomserver/storage/shared/storage.go index 9f3b8b1da..753ffff50 100644 --- a/roomserver/storage/shared/storage.go +++ b/roomserver/storage/shared/storage.go @@ -731,9 +731,6 @@ func (d *Database) assignEventTypeNID( eventTypeNID, err = d.EventTypesTable.SelectEventTypeNID(ctx, txn, eventType) } } - if err == nil { - d.Cache.StoreRoomServerEventTypeNID(eventType, eventTypeNID) - } return eventTypeNID, err } @@ -753,9 +750,6 @@ func (d *Database) assignStateKeyNID( eventStateKeyNID, err = d.EventStateKeysTable.SelectEventStateKeyNID(ctx, txn, eventStateKey) } } - if err == nil { - d.Cache.StoreRoomServerStateKeyNID(eventStateKey, eventStateKeyNID) - } return eventStateKeyNID, err }