From 4d1504ee93b008c7a266063a8eb0b309a01e625a Mon Sep 17 00:00:00 2001 From: Mark Haines Date: Mon, 7 Aug 2017 11:51:46 +0100 Subject: [PATCH] Add prefixes to namespace the SQL tables. (#177) * Add prefixes to namespace the SQL tables. This means that multiple components can share a single database schema without colliding with each other. Once this lands it will be possible to run a single monolithic dendrite against a single postgresql schema. Hopefully this will make trivial deployments and development easier. * Comment --- .../auth/storage/accounts/accounts_table.go | 8 ++-- .../auth/storage/accounts/membership_table.go | 14 +++---- .../auth/storage/accounts/profile_table.go | 10 ++--- .../auth/storage/accounts/storage.go | 2 +- .../auth/storage/devices/devices_table.go | 10 ++--- .../dendrite/common/keydb/server_key_table.go | 13 ++++--- .../dendrite/common/partition_offset_table.go | 25 ++++++++----- .../storage/joined_hosts_table.go | 16 ++++---- .../federationsender/storage/room_table.go | 8 ++-- .../federationsender/storage/storage.go | 2 +- .../storage/media_repository_table.go | 8 ++-- .../mediaapi/storage/thumbnail_table.go | 12 +++--- .../roomserver/storage/event_json_table.go | 7 ++-- .../storage/event_state_keys_table.go | 20 +++++----- .../roomserver/storage/event_types_table.go | 19 +++++----- .../roomserver/storage/events_table.go | 37 ++++++++++--------- .../storage/previous_events_table.go | 15 ++++---- .../roomserver/storage/room_aliases_table.go | 12 +++--- .../roomserver/storage/rooms_table.go | 21 ++++++----- .../roomserver/storage/state_block_table.go | 15 ++++---- .../storage/state_snapshot_table.go | 11 +++--- .../syncapi/storage/account_data_table.go | 12 +++--- .../storage/current_room_state_table.go | 25 +++++++------ .../storage/output_room_events_table.go | 19 ++++++---- .../dendrite/syncapi/storage/syncserver.go | 2 +- 25 files changed, 183 insertions(+), 160 deletions(-) diff --git a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/accounts_table.go b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/accounts_table.go index ad34a4004..d1177f3eb 100644 --- a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/accounts_table.go +++ b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/accounts_table.go @@ -25,7 +25,7 @@ import ( const accountsSchema = ` -- Stores data about accounts. -CREATE TABLE IF NOT EXISTS accounts ( +CREATE TABLE IF NOT EXISTS account_accounts ( -- The Matrix user ID localpart for this account localpart TEXT NOT NULL PRIMARY KEY, -- When this account was first created, as a unix timestamp (ms resolution). @@ -38,13 +38,13 @@ CREATE TABLE IF NOT EXISTS accounts ( ` const insertAccountSQL = "" + - "INSERT INTO accounts(localpart, created_ts, password_hash) VALUES ($1, $2, $3)" + "INSERT INTO account_accounts(localpart, created_ts, password_hash) VALUES ($1, $2, $3)" const selectAccountByLocalpartSQL = "" + - "SELECT localpart FROM accounts WHERE localpart = $1" + "SELECT localpart FROM account_accounts WHERE localpart = $1" const selectPasswordHashSQL = "" + - "SELECT password_hash FROM accounts WHERE localpart = $1" + "SELECT password_hash FROM account_accounts WHERE localpart = $1" // TODO: Update password diff --git a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/membership_table.go b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/membership_table.go index 70affdc33..42922743b 100644 --- a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/membership_table.go +++ b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/membership_table.go @@ -23,7 +23,7 @@ import ( const membershipSchema = ` -- Stores data about users memberships to rooms. -CREATE TABLE IF NOT EXISTS memberships ( +CREATE TABLE IF NOT EXISTS account_memberships ( -- The Matrix user ID localpart for the member localpart TEXT NOT NULL, -- The room this user is a member of @@ -36,25 +36,25 @@ CREATE TABLE IF NOT EXISTS memberships ( ); -- Use index to process deletion by ID more efficiently -CREATE UNIQUE INDEX IF NOT EXISTS membership_event_id ON memberships(event_id); +CREATE UNIQUE INDEX IF NOT EXISTS account_membership_event_id ON account_memberships(event_id); ` const insertMembershipSQL = ` - INSERT INTO memberships(localpart, room_id, event_id) VALUES ($1, $2, $3) + INSERT INTO account_memberships(localpart, room_id, event_id) VALUES ($1, $2, $3) ON CONFLICT (localpart, room_id) DO UPDATE SET event_id = EXCLUDED.event_id ` const selectMembershipSQL = "" + - "SELECT * from memberships WHERE localpart = $1 AND room_id = $2" + "SELECT * from account_memberships WHERE localpart = $1 AND room_id = $2" const selectMembershipsByLocalpartSQL = "" + - "SELECT room_id, event_id FROM memberships WHERE localpart = $1" + "SELECT room_id, event_id FROM account_memberships WHERE localpart = $1" const deleteMembershipsByEventIDsSQL = "" + - "DELETE FROM memberships WHERE event_id = ANY($1)" + "DELETE FROM account_memberships WHERE event_id = ANY($1)" const updateMembershipByEventIDSQL = "" + - "UPDATE memberships SET event_id = $2 WHERE event_id = $1" + "UPDATE account_memberships SET event_id = $2 WHERE event_id = $1" type membershipStatements struct { deleteMembershipsByEventIDsStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/profile_table.go b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/profile_table.go index 36416e077..2976c2765 100644 --- a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/profile_table.go +++ b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/profile_table.go @@ -22,7 +22,7 @@ import ( const profilesSchema = ` -- Stores data about accounts profiles. -CREATE TABLE IF NOT EXISTS profiles ( +CREATE TABLE IF NOT EXISTS account_profiles ( -- The Matrix user ID localpart for this account localpart TEXT NOT NULL PRIMARY KEY, -- The display name for this account @@ -33,16 +33,16 @@ CREATE TABLE IF NOT EXISTS profiles ( ` const insertProfileSQL = "" + - "INSERT INTO profiles(localpart, display_name, avatar_url) VALUES ($1, $2, $3)" + "INSERT INTO account_profiles(localpart, display_name, avatar_url) VALUES ($1, $2, $3)" const selectProfileByLocalpartSQL = "" + - "SELECT localpart, display_name, avatar_url FROM profiles WHERE localpart = $1" + "SELECT localpart, display_name, avatar_url FROM account_profiles WHERE localpart = $1" const setAvatarURLSQL = "" + - "UPDATE profiles SET avatar_url = $1 WHERE localpart = $2" + "UPDATE account_profiles SET avatar_url = $1 WHERE localpart = $2" const setDisplayNameSQL = "" + - "UPDATE profiles SET display_name = $1 WHERE localpart = $2" + "UPDATE account_profiles SET display_name = $1 WHERE localpart = $2" type profilesStatements struct { insertProfileStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/storage.go b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/storage.go index ca9deac09..fb98946a0 100644 --- a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/storage.go +++ b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/storage.go @@ -44,7 +44,7 @@ func NewDatabase(dataSourceName string, serverName gomatrixserverlib.ServerName) return nil, err } partitions := common.PartitionOffsetStatements{} - if err = partitions.Prepare(db); err != nil { + if err = partitions.Prepare(db, "account"); err != nil { return nil, err } a := accountsStatements{} diff --git a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/devices/devices_table.go b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/devices/devices_table.go index 9d6fade76..f346f1694 100644 --- a/src/github.com/matrix-org/dendrite/clientapi/auth/storage/devices/devices_table.go +++ b/src/github.com/matrix-org/dendrite/clientapi/auth/storage/devices/devices_table.go @@ -25,7 +25,7 @@ import ( const devicesSchema = ` -- Stores data about devices. -CREATE TABLE IF NOT EXISTS devices ( +CREATE TABLE IF NOT EXISTS device_devices ( -- The access token granted to this device. This has to be the primary key -- so we can distinguish which device is making a given request. access_token TEXT NOT NULL PRIMARY KEY, @@ -42,17 +42,17 @@ CREATE TABLE IF NOT EXISTS devices ( ); -- Device IDs must be unique for a given user. -CREATE UNIQUE INDEX IF NOT EXISTS localpart_id_idx ON devices(localpart, device_id); +CREATE UNIQUE INDEX IF NOT EXISTS device_localpart_id_idx ON device_devices(localpart, device_id); ` const insertDeviceSQL = "" + - "INSERT INTO devices(device_id, localpart, access_token, created_ts) VALUES ($1, $2, $3, $4)" + "INSERT INTO device_devices(device_id, localpart, access_token, created_ts) VALUES ($1, $2, $3, $4)" const selectDeviceByTokenSQL = "" + - "SELECT device_id, localpart FROM devices WHERE access_token = $1" + "SELECT device_id, localpart FROM device_devices WHERE access_token = $1" const deleteDeviceSQL = "" + - "DELETE FROM devices WHERE device_id = $1 AND localpart = $2" + "DELETE FROM device_devices WHERE device_id = $1 AND localpart = $2" // TODO: List devices? diff --git a/src/github.com/matrix-org/dendrite/common/keydb/server_key_table.go b/src/github.com/matrix-org/dendrite/common/keydb/server_key_table.go index d06b28225..936470d7b 100644 --- a/src/github.com/matrix-org/dendrite/common/keydb/server_key_table.go +++ b/src/github.com/matrix-org/dendrite/common/keydb/server_key_table.go @@ -17,13 +17,14 @@ package keydb import ( "database/sql" "encoding/json" + "github.com/lib/pq" "github.com/matrix-org/gomatrixserverlib" ) const serverKeysSchema = ` -- A cache of server keys downloaded from remote servers. -CREATE TABLE IF NOT EXISTS server_keys ( +CREATE TABLE IF NOT EXISTS keydb_server_keys ( -- The name of the matrix server the key is for. server_name TEXT NOT NULL, -- The ID of the server key. @@ -35,21 +36,21 @@ CREATE TABLE IF NOT EXISTS server_keys ( valid_until_ts BIGINT NOT NULL, -- The raw JSON for the server key. server_key_json TEXT NOT NULL, - CONSTRAINT server_keys_unique UNIQUE (server_name, server_key_id) + CONSTRAINT keydb_server_keys_unique UNIQUE (server_name, server_key_id) ); -CREATE INDEX IF NOT EXISTS server_name_and_key_id ON server_keys (server_name_and_key_id); +CREATE INDEX IF NOT EXISTS keydb_server_name_and_key_id ON keydb_server_keys (server_name_and_key_id); ` const bulkSelectServerKeysSQL = "" + - "SELECT server_name, server_key_id, server_key_json FROM server_keys" + + "SELECT server_name, server_key_id, server_key_json FROM keydb_server_keys" + " WHERE server_name_and_key_id = ANY($1)" const upsertServerKeysSQL = "" + - "INSERT INTO server_keys (server_name, server_key_id," + + "INSERT INTO keydb_server_keys (server_name, server_key_id," + " server_name_and_key_id, valid_until_ts, server_key_json)" + " VALUES ($1, $2, $3, $4, $5)" + - " ON CONFLICT ON CONSTRAINT server_keys_unique" + + " ON CONFLICT ON CONSTRAINT keydb_server_keys_unique" + " DO UPDATE SET valid_until_ts = $4, server_key_json = $5" type serverKeyStatements struct { diff --git a/src/github.com/matrix-org/dendrite/common/partition_offset_table.go b/src/github.com/matrix-org/dendrite/common/partition_offset_table.go index 627ce2f95..3898cc1f7 100644 --- a/src/github.com/matrix-org/dendrite/common/partition_offset_table.go +++ b/src/github.com/matrix-org/dendrite/common/partition_offset_table.go @@ -15,26 +15,27 @@ package common import "database/sql" +import "strings" const partitionOffsetsSchema = ` -- The offsets that the server has processed up to. -CREATE TABLE IF NOT EXISTS partition_offsets ( +CREATE TABLE IF NOT EXISTS ${prefix}_partition_offsets ( -- The name of the topic. topic TEXT NOT NULL, -- The 32-bit partition ID partition INTEGER NOT NULL, -- The 64-bit offset. partition_offset BIGINT NOT NULL, - CONSTRAINT topic_partition_unique UNIQUE (topic, partition) + CONSTRAINT ${prefix}_topic_partition_unique UNIQUE (topic, partition) ); ` const selectPartitionOffsetsSQL = "" + - "SELECT partition, partition_offset FROM partition_offsets WHERE topic = $1" + "SELECT partition, partition_offset FROM ${prefix}_partition_offsets WHERE topic = $1" const upsertPartitionOffsetsSQL = "" + - "INSERT INTO partition_offsets (topic, partition, partition_offset) VALUES ($1, $2, $3)" + - " ON CONFLICT ON CONSTRAINT topic_partition_unique" + + "INSERT INTO ${prefix}_partition_offsets (topic, partition, partition_offset) VALUES ($1, $2, $3)" + + " ON CONFLICT ON CONSTRAINT ${prefix}_topic_partition_unique" + " DO UPDATE SET partition_offset = $3" // PartitionOffsetStatements represents a set of statements that can be run on a partition_offsets table. @@ -44,15 +45,21 @@ type PartitionOffsetStatements struct { } // Prepare converts the raw SQL statements into prepared statements. -func (s *PartitionOffsetStatements) Prepare(db *sql.DB) (err error) { - _, err = db.Exec(partitionOffsetsSchema) +// Takes a prefix to prepend to the table name used to store the partition offsets. +// This allows multiple components to share the same database schema. +func (s *PartitionOffsetStatements) Prepare(db *sql.DB, prefix string) (err error) { + _, err = db.Exec(strings.Replace(partitionOffsetsSchema, "${prefix}", prefix, -1)) if err != nil { return } - if s.selectPartitionOffsetsStmt, err = db.Prepare(selectPartitionOffsetsSQL); err != nil { + if s.selectPartitionOffsetsStmt, err = db.Prepare( + strings.Replace(selectPartitionOffsetsSQL, "${prefix}", prefix, -1), + ); err != nil { return } - if s.upsertPartitionOffsetStmt, err = db.Prepare(upsertPartitionOffsetsSQL); err != nil { + if s.upsertPartitionOffsetStmt, err = db.Prepare( + strings.Replace(upsertPartitionOffsetsSQL, "${prefix}", prefix, -1), + ); err != nil { return } return diff --git a/src/github.com/matrix-org/dendrite/federationsender/storage/joined_hosts_table.go b/src/github.com/matrix-org/dendrite/federationsender/storage/joined_hosts_table.go index 1b5c65ddf..7ba1b0b07 100644 --- a/src/github.com/matrix-org/dendrite/federationsender/storage/joined_hosts_table.go +++ b/src/github.com/matrix-org/dendrite/federationsender/storage/joined_hosts_table.go @@ -26,7 +26,7 @@ const joinedHostsSchema = ` -- The joined_hosts table stores a list of m.room.member event ids in the -- current state for each room where the membership is "join". -- There will be an entry for every user that is joined to the room. -CREATE TABLE IF NOT EXISTS joined_hosts ( +CREATE TABLE IF NOT EXISTS federationsender_joined_hosts ( -- The string ID of the room. room_id TEXT NOT NULL, -- The event ID of the m.room.member join event. @@ -35,22 +35,22 @@ CREATE TABLE IF NOT EXISTS joined_hosts ( server_name TEXT NOT NULL ); -CREATE UNIQUE INDEX IF NOT EXISTS joined_hosts_event_id_idx - ON joined_hosts (event_id); +CREATE UNIQUE INDEX IF NOT EXISTS federatonsender_joined_hosts_event_id_idx + ON federationsender_joined_hosts (event_id); -CREATE INDEX IF NOT EXISTS joined_hosts_room_id_idx - ON joined_hosts (room_id) +CREATE INDEX IF NOT EXISTS federatonsender_joined_hosts_room_id_idx + ON federationsender_joined_hosts (room_id) ` const insertJoinedHostsSQL = "" + - "INSERT INTO joined_hosts (room_id, event_id, server_name)" + + "INSERT INTO federationsender_joined_hosts (room_id, event_id, server_name)" + " VALUES ($1, $2, $3)" const deleteJoinedHostsSQL = "" + - "DELETE FROM joined_hosts WHERE event_id = ANY($1)" + "DELETE FROM federationsender_joined_hosts WHERE event_id = ANY($1)" const selectJoinedHostsSQL = "" + - "SELECT event_id, server_name FROM joined_hosts" + + "SELECT event_id, server_name FROM federationsender_joined_hosts" + " WHERE room_id = $1" type joinedHostsStatements struct { diff --git a/src/github.com/matrix-org/dendrite/federationsender/storage/room_table.go b/src/github.com/matrix-org/dendrite/federationsender/storage/room_table.go index e11ed4213..daac7ddf4 100644 --- a/src/github.com/matrix-org/dendrite/federationsender/storage/room_table.go +++ b/src/github.com/matrix-org/dendrite/federationsender/storage/room_table.go @@ -19,7 +19,7 @@ import ( ) const roomSchema = ` -CREATE TABLE IF NOT EXISTS rooms ( +CREATE TABLE IF NOT EXISTS federationsender_rooms ( -- The string ID of the room room_id TEXT PRIMARY KEY, -- The most recent event state by the room server. @@ -29,14 +29,14 @@ CREATE TABLE IF NOT EXISTS rooms ( );` const insertRoomSQL = "" + - "INSERT INTO rooms (room_id, last_event_id) VALUES ($1, '')" + + "INSERT INTO federationsender_rooms (room_id, last_event_id) VALUES ($1, '')" + " ON CONFLICT DO NOTHING" const selectRoomForUpdateSQL = "" + - "SELECT last_event_id FROM rooms WHERE room_id = $1 FOR UPDATE" + "SELECT last_event_id FROM federationsender_rooms WHERE room_id = $1 FOR UPDATE" const updateRoomSQL = "" + - "UPDATE rooms SET last_event_id = $2 WHERE room_id = $1" + "UPDATE federationsender_rooms SET last_event_id = $2 WHERE room_id = $1" type roomStatements struct { insertRoomStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/federationsender/storage/storage.go b/src/github.com/matrix-org/dendrite/federationsender/storage/storage.go index a10210076..874585345 100644 --- a/src/github.com/matrix-org/dendrite/federationsender/storage/storage.go +++ b/src/github.com/matrix-org/dendrite/federationsender/storage/storage.go @@ -53,7 +53,7 @@ func (d *Database) prepare() error { return err } - if err = d.PartitionOffsetStatements.Prepare(d.db); err != nil { + if err = d.PartitionOffsetStatements.Prepare(d.db, "federationsender"); err != nil { return err } diff --git a/src/github.com/matrix-org/dendrite/mediaapi/storage/media_repository_table.go b/src/github.com/matrix-org/dendrite/mediaapi/storage/media_repository_table.go index 99df713df..8a61fd7da 100644 --- a/src/github.com/matrix-org/dendrite/mediaapi/storage/media_repository_table.go +++ b/src/github.com/matrix-org/dendrite/mediaapi/storage/media_repository_table.go @@ -25,7 +25,7 @@ import ( const mediaSchema = ` -- The media_repository table holds metadata for each media file stored and accessible to the local server, -- the actual file is stored separately. -CREATE TABLE IF NOT EXISTS media_repository ( +CREATE TABLE IF NOT EXISTS mediaapi_media_repository ( -- The id used to refer to the media. -- For uploads to this server this is a base64-encoded sha256 hash of the file data -- For media from remote servers, this can be any unique identifier string @@ -45,16 +45,16 @@ CREATE TABLE IF NOT EXISTS media_repository ( -- The user who uploaded the file. Should be a Matrix user ID. user_id TEXT NOT NULL ); -CREATE UNIQUE INDEX IF NOT EXISTS media_repository_index ON media_repository (media_id, media_origin); +CREATE UNIQUE INDEX IF NOT EXISTS mediaapi_media_repository_index ON mediaapi_media_repository (media_id, media_origin); ` const insertMediaSQL = ` -INSERT INTO media_repository (media_id, media_origin, content_type, file_size_bytes, creation_ts, upload_name, base64hash, user_id) +INSERT INTO mediaapi_media_repository (media_id, media_origin, content_type, file_size_bytes, creation_ts, upload_name, base64hash, user_id) VALUES ($1, $2, $3, $4, $5, $6, $7, $8) ` const selectMediaSQL = ` -SELECT content_type, file_size_bytes, creation_ts, upload_name, base64hash, user_id FROM media_repository WHERE media_id = $1 AND media_origin = $2 +SELECT content_type, file_size_bytes, creation_ts, upload_name, base64hash, user_id FROM mediaapi_media_repository WHERE media_id = $1 AND media_origin = $2 ` type mediaStatements struct { diff --git a/src/github.com/matrix-org/dendrite/mediaapi/storage/thumbnail_table.go b/src/github.com/matrix-org/dendrite/mediaapi/storage/thumbnail_table.go index 1284dbd48..5d806da03 100644 --- a/src/github.com/matrix-org/dendrite/mediaapi/storage/thumbnail_table.go +++ b/src/github.com/matrix-org/dendrite/mediaapi/storage/thumbnail_table.go @@ -23,9 +23,9 @@ import ( ) const thumbnailSchema = ` --- The thumbnail table holds metadata for each thumbnail file stored and accessible to the local server, +-- The mediaapi_thumbnail table holds metadata for each thumbnail file stored and accessible to the local server, -- the actual file is stored separately. -CREATE TABLE IF NOT EXISTS thumbnail ( +CREATE TABLE IF NOT EXISTS mediaapi_thumbnail ( -- The id used to refer to the media. -- For uploads to this server this is a base64-encoded sha256 hash of the file data -- For media from remote servers, this can be any unique identifier string @@ -45,22 +45,22 @@ CREATE TABLE IF NOT EXISTS thumbnail ( -- The resize method used to generate the thumbnail. Can be crop or scale. resize_method TEXT NOT NULL ); -CREATE UNIQUE INDEX IF NOT EXISTS thumbnail_index ON thumbnail (media_id, media_origin, width, height, resize_method); +CREATE UNIQUE INDEX IF NOT EXISTS mediaapi_thumbnail_index ON mediaapi_thumbnail (media_id, media_origin, width, height, resize_method); ` const insertThumbnailSQL = ` -INSERT INTO thumbnail (media_id, media_origin, content_type, file_size_bytes, creation_ts, width, height, resize_method) +INSERT INTO mediaapi_thumbnail (media_id, media_origin, content_type, file_size_bytes, creation_ts, width, height, resize_method) VALUES ($1, $2, $3, $4, $5, $6, $7, $8) ` // Note: this selects one specific thumbnail const selectThumbnailSQL = ` -SELECT content_type, file_size_bytes, creation_ts FROM thumbnail WHERE media_id = $1 AND media_origin = $2 AND width = $3 AND height = $4 AND resize_method = $5 +SELECT content_type, file_size_bytes, creation_ts FROM mediaapi_thumbnail WHERE media_id = $1 AND media_origin = $2 AND width = $3 AND height = $4 AND resize_method = $5 ` // Note: this selects all thumbnails for a media_origin and media_id const selectThumbnailsSQL = ` -SELECT content_type, file_size_bytes, creation_ts, width, height, resize_method FROM thumbnail WHERE media_id = $1 AND media_origin = $2 +SELECT content_type, file_size_bytes, creation_ts, width, height, resize_method FROM mediaapi_thumbnail WHERE media_id = $1 AND media_origin = $2 ` type thumbnailStatements struct { diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/event_json_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/event_json_table.go index d81f44944..5e203b4fc 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/event_json_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/event_json_table.go @@ -16,13 +16,14 @@ package storage import ( "database/sql" + "github.com/matrix-org/dendrite/roomserver/types" ) const eventJSONSchema = ` -- Stores the JSON for each event. This kept separate from the main events -- table to keep the rows in the main events table small. -CREATE TABLE IF NOT EXISTS event_json ( +CREATE TABLE IF NOT EXISTS roomserver_event_json ( -- Local numeric ID for the event. event_nid BIGINT NOT NULL PRIMARY KEY, -- The JSON for the event. @@ -37,14 +38,14 @@ CREATE TABLE IF NOT EXISTS event_json ( ` const insertEventJSONSQL = "" + - "INSERT INTO event_json (event_nid, event_json) VALUES ($1, $2)" + + "INSERT INTO roomserver_event_json (event_nid, event_json) VALUES ($1, $2)" + " ON CONFLICT DO NOTHING" // Bulk event JSON lookup by numeric event ID. // Sort by the numeric event ID. // This means that we can use binary search to lookup by numeric event ID. const bulkSelectEventJSONSQL = "" + - "SELECT event_nid, event_json FROM event_json" + + "SELECT event_nid, event_json FROM roomserver_event_json" + " WHERE event_nid = ANY($1)" + " ORDER BY event_nid ASC" diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/event_state_keys_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/event_state_keys_table.go index a08967d98..da5b8a4e5 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/event_state_keys_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/event_state_keys_table.go @@ -16,6 +16,7 @@ package storage import ( "database/sql" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" ) @@ -31,29 +32,30 @@ const eventStateKeysSchema = ` -- Other state keys are automatically assigned numeric IDs starting from 2**16. -- This leaves room to add more pre-assigned numeric IDs and clearly separates -- the automatically assigned IDs from the pre-assigned IDs. -CREATE SEQUENCE IF NOT EXISTS event_state_key_nid_seq START 65536; -CREATE TABLE IF NOT EXISTS event_state_keys ( +CREATE SEQUENCE IF NOT EXISTS roomserver_event_state_key_nid_seq START 65536; +CREATE TABLE IF NOT EXISTS roomserver_event_state_keys ( -- Local numeric ID for the state key. - event_state_key_nid BIGINT PRIMARY KEY DEFAULT nextval('event_state_key_nid_seq'), - event_state_key TEXT NOT NULL CONSTRAINT event_state_key_unique UNIQUE + event_state_key_nid BIGINT PRIMARY KEY DEFAULT nextval('roomserver_event_state_key_nid_seq'), + event_state_key TEXT NOT NULL CONSTRAINT roomserver_event_state_key_unique UNIQUE ); -INSERT INTO event_state_keys (event_state_key_nid, event_state_key) VALUES +INSERT INTO roomserver_event_state_keys (event_state_key_nid, event_state_key) VALUES (1, '') ON CONFLICT DO NOTHING; ` // Same as insertEventTypeNIDSQL const insertEventStateKeyNIDSQL = "" + - "INSERT INTO event_state_keys (event_state_key) VALUES ($1)" + - " ON CONFLICT ON CONSTRAINT event_state_key_unique" + + "INSERT INTO roomserver_event_state_keys (event_state_key) VALUES ($1)" + + " ON CONFLICT ON CONSTRAINT roomserver_event_state_key_unique" + " DO NOTHING RETURNING (event_state_key_nid)" const selectEventStateKeyNIDSQL = "" + - "SELECT event_state_key_nid FROM event_state_keys WHERE event_state_key = $1" + "SELECT event_state_key_nid FROM roomserver_event_state_keys" + + " WHERE event_state_key = $1" // Bulk lookup from string state key to numeric ID for that state key. // Takes an array of strings as the query parameter. const bulkSelectEventStateKeyNIDSQL = "" + - "SELECT event_state_key, event_state_key_nid FROM event_state_keys" + + "SELECT event_state_key, event_state_key_nid FROM roomserver_event_state_keys" + " WHERE event_state_key = ANY($1)" type eventStateKeyStatements struct { diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/event_types_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/event_types_table.go index d68783286..7c0bf9b12 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/event_types_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/event_types_table.go @@ -16,6 +16,7 @@ package storage import ( "database/sql" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" ) @@ -43,14 +44,14 @@ const eventTypesSchema = ` -- Other event types are automatically assigned numeric IDs starting from 2**16. -- This leaves room to add more pre-assigned numeric IDs and clearly separates -- the automatically assigned IDs from the pre-assigned IDs. -CREATE SEQUENCE IF NOT EXISTS event_type_nid_seq START 65536; -CREATE TABLE IF NOT EXISTS event_types ( +CREATE SEQUENCE IF NOT EXISTS roomserver_event_type_nid_seq START 65536; +CREATE TABLE IF NOT EXISTS roomserver_event_types ( -- Local numeric ID for the event type. - event_type_nid BIGINT PRIMARY KEY DEFAULT nextval('event_type_nid_seq'), + event_type_nid BIGINT PRIMARY KEY DEFAULT nextval('roomserver_event_type_nid_seq'), -- The string event_type. - event_type TEXT NOT NULL CONSTRAINT event_type_unique UNIQUE + event_type TEXT NOT NULL CONSTRAINT roomserver_event_type_unique UNIQUE ); -INSERT INTO event_types (event_type_nid, event_type) VALUES +INSERT INTO roomserver_event_types (event_type_nid, event_type) VALUES (1, 'm.room.create'), (2, 'm.room.power_levels'), (3, 'm.room.join_rules'), @@ -74,17 +75,17 @@ INSERT INTO event_types (event_type_nid, event_type) VALUES // row even though the data doesn't change resulting in unncesssary modifications // to the indexes. const insertEventTypeNIDSQL = "" + - "INSERT INTO event_types (event_type) VALUES ($1)" + - " ON CONFLICT ON CONSTRAINT event_type_unique" + + "INSERT INTO roomserver_event_types (event_type) VALUES ($1)" + + " ON CONFLICT ON CONSTRAINT roomserver_event_type_unique" + " DO NOTHING RETURNING (event_type_nid)" const selectEventTypeNIDSQL = "" + - "SELECT event_type_nid FROM event_types WHERE event_type = $1" + "SELECT event_type_nid FROM roomserver_event_types WHERE event_type = $1" // Bulk lookup from string event type to numeric ID for that event type. // Takes an array of strings as the query parameter. const bulkSelectEventTypeNIDSQL = "" + - "SELECT event_type, event_type_nid FROM event_types" + + "SELECT event_type, event_type_nid FROM roomserver_event_types" + " WHERE event_type = ANY($1)" type eventTypeStatements struct { diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/events_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/events_table.go index b4f1bfa39..b6db15c82 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/events_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/events_table.go @@ -17,6 +17,7 @@ package storage import ( "database/sql" "fmt" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" "github.com/matrix-org/gomatrixserverlib" @@ -25,10 +26,10 @@ import ( const eventsSchema = ` -- The events table holds metadata for each event, the actual JSON is stored -- separately to keep the size of the rows small. -CREATE SEQUENCE IF NOT EXISTS event_nid_seq; -CREATE TABLE IF NOT EXISTS events ( +CREATE SEQUENCE IF NOT EXISTS roomserver_event_nid_seq; +CREATE TABLE IF NOT EXISTS roomserver_events ( -- Local numeric ID for the event. - event_nid BIGINT PRIMARY KEY DEFAULT nextval('event_nid_seq'), + event_nid BIGINT PRIMARY KEY DEFAULT nextval('roomserver_event_nid_seq'), -- Local numeric ID for the room the event is in. -- This is never 0. room_nid BIGINT NOT NULL, @@ -53,7 +54,7 @@ CREATE TABLE IF NOT EXISTS events ( -- Used to lookup the numeric ID when processing requests. -- Needed for state resolution. -- An event may only appear in this table once. - event_id TEXT NOT NULL CONSTRAINT event_id_unique UNIQUE, + event_id TEXT NOT NULL CONSTRAINT roomserver_event_id_unique UNIQUE, -- The sha256 reference hash for the event. -- Needed for setting reference hashes when sending new events. reference_sha256 BYTEA NOT NULL, @@ -63,54 +64,54 @@ CREATE TABLE IF NOT EXISTS events ( ` const insertEventSQL = "" + - "INSERT INTO events (room_nid, event_type_nid, event_state_key_nid, event_id, reference_sha256, auth_event_nids, depth)" + + "INSERT INTO roomserver_events (room_nid, event_type_nid, event_state_key_nid, event_id, reference_sha256, auth_event_nids, depth)" + " VALUES ($1, $2, $3, $4, $5, $6, $7)" + - " ON CONFLICT ON CONSTRAINT event_id_unique" + + " ON CONFLICT ON CONSTRAINT roomserver_event_id_unique" + " DO NOTHING" + " RETURNING event_nid, state_snapshot_nid" const selectEventSQL = "" + - "SELECT event_nid, state_snapshot_nid FROM events WHERE event_id = $1" + "SELECT event_nid, state_snapshot_nid FROM roomserver_events WHERE event_id = $1" // Bulk lookup of events by string ID. // Sort by the numeric IDs for event type and state key. // This means we can use binary search to lookup entries by type and state key. const bulkSelectStateEventByIDSQL = "" + - "SELECT event_type_nid, event_state_key_nid, event_nid FROM events" + + "SELECT event_type_nid, event_state_key_nid, event_nid FROM roomserver_events" + " WHERE event_id = ANY($1)" + " ORDER BY event_type_nid, event_state_key_nid ASC" const bulkSelectStateAtEventByIDSQL = "" + - "SELECT event_type_nid, event_state_key_nid, event_nid, state_snapshot_nid FROM events" + + "SELECT event_type_nid, event_state_key_nid, event_nid, state_snapshot_nid FROM roomserver_events" + " WHERE event_id = ANY($1)" const updateEventStateSQL = "" + - "UPDATE events SET state_snapshot_nid = $2 WHERE event_nid = $1" + "UPDATE roomserver_events SET state_snapshot_nid = $2 WHERE event_nid = $1" const selectEventSentToOutputSQL = "" + - "SELECT sent_to_output FROM events WHERE event_nid = $1" + "SELECT sent_to_output FROM roomserver_events WHERE event_nid = $1" const updateEventSentToOutputSQL = "" + - "UPDATE events SET sent_to_output = TRUE WHERE event_nid = $1" + "UPDATE roomserver_events SET sent_to_output = TRUE WHERE event_nid = $1" const selectEventIDSQL = "" + - "SELECT event_id FROM events WHERE event_nid = $1" + "SELECT event_id FROM roomserver_events WHERE event_nid = $1" const bulkSelectStateAtEventAndReferenceSQL = "" + "SELECT event_type_nid, event_state_key_nid, event_nid, state_snapshot_nid, event_id, reference_sha256" + - " FROM events WHERE event_nid = ANY($1)" + " FROM roomserver_events WHERE event_nid = ANY($1)" const bulkSelectEventReferenceSQL = "" + - "SELECT event_id, reference_sha256 FROM events WHERE event_nid = ANY($1)" + "SELECT event_id, reference_sha256 FROM roomserver_events WHERE event_nid = ANY($1)" const bulkSelectEventIDSQL = "" + - "SELECT event_nid, event_id FROM events WHERE event_nid = ANY($1)" + "SELECT event_nid, event_id FROM roomserver_events WHERE event_nid = ANY($1)" const bulkSelectEventNIDSQL = "" + - "SELECT event_id, event_nid FROM events WHERE event_id = ANY($1)" + "SELECT event_id, event_nid FROM roomserver_events WHERE event_id = ANY($1)" const selectMaxEventDepthSQL = "" + - "SELECT COALESCE(MAX(depth) + 1, 0) FROM events WHERE event_nid = ANY($1)" + "SELECT COALESCE(MAX(depth) + 1, 0) FROM roomserver_events WHERE event_nid = ANY($1)" type eventStatements struct { insertEventStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/previous_events_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/previous_events_table.go index cc5c3a134..71795d488 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/previous_events_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/previous_events_table.go @@ -16,6 +16,7 @@ package storage import ( "database/sql" + "github.com/matrix-org/dendrite/roomserver/types" ) @@ -24,14 +25,14 @@ const previousEventSchema = ` -- stored in the events table. -- This is used to tell if a new event is already referenced by an event in -- the database. -CREATE TABLE IF NOT EXISTS previous_events ( +CREATE TABLE IF NOT EXISTS roomserver_previous_events ( -- The string event ID taken from the prev_events key of an event. previous_event_id TEXT NOT NULL, -- The SHA256 reference hash taken from the prev_events key of an event. previous_reference_sha256 BYTEA NOT NULL, -- A list of numeric event IDs of events that reference this prev_event. event_nids BIGINT[] NOT NULL, - CONSTRAINT previous_event_id_unique UNIQUE (previous_event_id, previous_reference_sha256) + CONSTRAINT roomserver_previous_event_id_unique UNIQUE (previous_event_id, previous_reference_sha256) ); ` @@ -41,17 +42,17 @@ CREATE TABLE IF NOT EXISTS previous_events ( // This should only be modified while holding a "FOR UPDATE" lock on the row in the rooms table for this room. // The lock is necessary to avoid data races when checking whether an event is already referenced by another event. const insertPreviousEventSQL = "" + - "INSERT INTO previous_events" + + "INSERT INTO roomserver_previous_events" + " (previous_event_id, previous_reference_sha256, event_nids)" + " VALUES ($1, $2, array_append('{}'::bigint[], $3))" + - " ON CONFLICT ON CONSTRAINT previous_event_id_unique" + - " DO UPDATE SET event_nids = array_append(previous_events.event_nids, $3)" + - " WHERE $3 != ALL(previous_events.event_nids)" + " ON CONFLICT ON CONSTRAINT roomserver_previous_event_id_unique" + + " DO UPDATE SET event_nids = array_append(roomserver_previous_events.event_nids, $3)" + + " WHERE $3 != ALL(roomserver_previous_events.event_nids)" // Check if the event is referenced by another event in the table. // This should only be done while holding a "FOR UPDATE" lock on the row in the rooms table for this room. const selectPreviousEventExistsSQL = "" + - "SELECT 1 FROM previous_events" + + "SELECT 1 FROM roomserver_previous_events" + " WHERE previous_event_id = $1 AND previous_reference_sha256 = $2" type previousEventStatements struct { diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/room_aliases_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/room_aliases_table.go index 8b56b6d14..433835d7a 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/room_aliases_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/room_aliases_table.go @@ -20,27 +20,27 @@ import ( const roomAliasesSchema = ` -- Stores room aliases and room IDs they refer to -CREATE TABLE IF NOT EXISTS room_aliases ( +CREATE TABLE IF NOT EXISTS roomserver_room_aliases ( -- Alias of the room alias TEXT NOT NULL PRIMARY KEY, -- Room ID the alias refers to room_id TEXT NOT NULL ); -CREATE UNIQUE INDEX IF NOT EXISTS room_id_idx ON room_aliases(room_id); +CREATE UNIQUE INDEX IF NOT EXISTS roomserver_room_id_idx ON roomserver_room_aliases(room_id); ` const insertRoomAliasSQL = "" + - "INSERT INTO room_aliases (alias, room_id) VALUES ($1, $2)" + "INSERT INTO roomserver_room_aliases (alias, room_id) VALUES ($1, $2)" const selectRoomIDFromAliasSQL = "" + - "SELECT room_id FROM room_aliases WHERE alias = $1" + "SELECT room_id FROM roomserver_room_aliases WHERE alias = $1" const selectAliasesFromRoomIDSQL = "" + - "SELECT alias FROM room_aliases WHERE room_id = $1" + "SELECT alias FROM roomserver_room_aliases WHERE room_id = $1" const deleteRoomAliasSQL = "" + - "DELETE FROM room_aliases WHERE alias = $1" + "DELETE FROM roomserver_room_aliases WHERE alias = $1" type roomAliasesStatements struct { insertRoomAliasStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/rooms_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/rooms_table.go index 7c635420a..03cacd7db 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/rooms_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/rooms_table.go @@ -16,17 +16,18 @@ package storage import ( "database/sql" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" ) const roomsSchema = ` -CREATE SEQUENCE IF NOT EXISTS room_nid_seq; -CREATE TABLE IF NOT EXISTS rooms ( +CREATE SEQUENCE IF NOT EXISTS roomserver_room_nid_seq; +CREATE TABLE IF NOT EXISTS roomserver_rooms ( -- Local numeric ID for the room. - room_nid BIGINT PRIMARY KEY DEFAULT nextval('room_nid_seq'), + room_nid BIGINT PRIMARY KEY DEFAULT nextval('roomserver_room_nid_seq'), -- Textual ID for the room. - room_id TEXT NOT NULL CONSTRAINT room_id_unique UNIQUE, + room_id TEXT NOT NULL CONSTRAINT roomserver_room_id_unique UNIQUE, -- The most recent events in the room that aren't referenced by another event. -- This list may empty if the server hasn't joined the room yet. -- (The server will be in that state while it stores the events for the initial state of the room) @@ -41,21 +42,21 @@ CREATE TABLE IF NOT EXISTS rooms ( // Same as insertEventTypeNIDSQL const insertRoomNIDSQL = "" + - "INSERT INTO rooms (room_id) VALUES ($1)" + - " ON CONFLICT ON CONSTRAINT room_id_unique" + + "INSERT INTO roomserver_rooms (room_id) VALUES ($1)" + + " ON CONFLICT ON CONSTRAINT roomserver_room_id_unique" + " DO NOTHING RETURNING (room_nid)" const selectRoomNIDSQL = "" + - "SELECT room_nid FROM rooms WHERE room_id = $1" + "SELECT room_nid FROM roomserver_rooms WHERE room_id = $1" const selectLatestEventNIDsSQL = "" + - "SELECT latest_event_nids, state_snapshot_nid FROM rooms WHERE room_nid = $1" + "SELECT latest_event_nids, state_snapshot_nid FROM roomserver_rooms WHERE room_nid = $1" const selectLatestEventNIDsForUpdateSQL = "" + - "SELECT latest_event_nids, last_event_sent_nid, state_snapshot_nid FROM rooms WHERE room_nid = $1 FOR UPDATE" + "SELECT latest_event_nids, last_event_sent_nid, state_snapshot_nid FROM roomserver_rooms WHERE room_nid = $1 FOR UPDATE" const updateLatestEventNIDsSQL = "" + - "UPDATE rooms SET latest_event_nids = $2, last_event_sent_nid = $3, state_snapshot_nid = $4 WHERE room_nid = $1" + "UPDATE roomserver_rooms SET latest_event_nids = $2, last_event_sent_nid = $3, state_snapshot_nid = $4 WHERE room_nid = $1" type roomStatements struct { insertRoomNIDStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/state_block_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/state_block_table.go index b90809cef..343e9395c 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/state_block_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/state_block_table.go @@ -17,10 +17,11 @@ package storage import ( "database/sql" "fmt" + "sort" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" "github.com/matrix-org/util" - "sort" ) const stateDataSchema = ` @@ -33,8 +34,8 @@ const stateDataSchema = ` -- lookup a specific (type, state_key) pair for an event. It also makes it easy -- to read the state for a given state_block_nid ordered by (type, state_key) -- which in turn makes it easier to merge state data blocks. -CREATE SEQUENCE IF NOT EXISTS state_block_nid_seq; -CREATE TABLE IF NOT EXISTS state_block ( +CREATE SEQUENCE IF NOT EXISTS roomserver_state_block_nid_seq; +CREATE TABLE IF NOT EXISTS roomserver_state_block ( -- Local numeric ID for this state data. state_block_nid bigint NOT NULL, event_type_nid bigint NOT NULL, @@ -45,11 +46,11 @@ CREATE TABLE IF NOT EXISTS state_block ( ` const insertStateDataSQL = "" + - "INSERT INTO state_block (state_block_nid, event_type_nid, event_state_key_nid, event_nid)" + + "INSERT INTO roomserver_state_block (state_block_nid, event_type_nid, event_state_key_nid, event_nid)" + " VALUES ($1, $2, $3, $4)" const selectNextStateBlockNIDSQL = "" + - "SELECT nextval('state_block_nid_seq')" + "SELECT nextval('roomserver_state_block_nid_seq')" // Bulk state lookup by numeric state block ID. // Sort by the state_block_nid, event_type_nid, event_state_key_nid @@ -59,7 +60,7 @@ const selectNextStateBlockNIDSQL = "" + // state data blocks together. const bulkSelectStateBlockEntriesSQL = "" + "SELECT state_block_nid, event_type_nid, event_state_key_nid, event_nid" + - " FROM state_block WHERE state_block_nid = ANY($1)" + + " FROM roomserver_state_block WHERE state_block_nid = ANY($1)" + " ORDER BY state_block_nid, event_type_nid, event_state_key_nid" // Bulk state lookup by numeric state block ID. @@ -71,7 +72,7 @@ const bulkSelectStateBlockEntriesSQL = "" + // actually wanted. const bulkSelectFilteredStateBlockEntriesSQL = "" + "SELECT state_block_nid, event_type_nid, event_state_key_nid, event_nid" + - " FROM state_block WHERE state_block_nid = ANY($1)" + + " FROM roomserver_state_block WHERE state_block_nid = ANY($1)" + " AND event_type_nid = ANY($2) AND event_state_key_nid = ANY($3)" + " ORDER BY state_block_nid, event_type_nid, event_state_key_nid" diff --git a/src/github.com/matrix-org/dendrite/roomserver/storage/state_snapshot_table.go b/src/github.com/matrix-org/dendrite/roomserver/storage/state_snapshot_table.go index eaca37831..4d5886621 100644 --- a/src/github.com/matrix-org/dendrite/roomserver/storage/state_snapshot_table.go +++ b/src/github.com/matrix-org/dendrite/roomserver/storage/state_snapshot_table.go @@ -17,6 +17,7 @@ package storage import ( "database/sql" "fmt" + "github.com/lib/pq" "github.com/matrix-org/dendrite/roomserver/types" ) @@ -32,10 +33,10 @@ const stateSnapshotSchema = ` -- because room state tends to accumulate small changes over time. Although if -- the list of deltas becomes too long it becomes more efficient to encode -- the full state under single state_block_nid. -CREATE SEQUENCE IF NOT EXISTS state_snapshot_nid_seq; -CREATE TABLE IF NOT EXISTS state_snapshots ( +CREATE SEQUENCE IF NOT EXISTS roomserver_state_snapshot_nid_seq; +CREATE TABLE IF NOT EXISTS roomserver_state_snapshots ( -- Local numeric ID for the state. - state_snapshot_nid bigint PRIMARY KEY DEFAULT nextval('state_snapshot_nid_seq'), + state_snapshot_nid bigint PRIMARY KEY DEFAULT nextval('roomserver_state_snapshot_nid_seq'), -- Local numeric ID of the room this state is for. -- Unused in normal operation, but useful for background work or ad-hoc debugging. room_nid bigint NOT NULL, @@ -45,7 +46,7 @@ CREATE TABLE IF NOT EXISTS state_snapshots ( ` const insertStateSQL = "" + - "INSERT INTO state_snapshots (room_nid, state_block_nids)" + + "INSERT INTO roomserver_state_snapshots (room_nid, state_block_nids)" + " VALUES ($1, $2)" + " RETURNING state_snapshot_nid" @@ -53,7 +54,7 @@ const insertStateSQL = "" + // Sorting by state_snapshot_nid means we can use binary search over the result // to lookup the state data NIDs for a state snapshot NID. const bulkSelectStateBlockNIDsSQL = "" + - "SELECT state_snapshot_nid, state_block_nids FROM state_snapshots" + + "SELECT state_snapshot_nid, state_block_nids FROM roomserver_state_snapshots" + " WHERE state_snapshot_nid = ANY($1) ORDER BY state_snapshot_nid ASC" type stateSnapshotStatements struct { diff --git a/src/github.com/matrix-org/dendrite/syncapi/storage/account_data_table.go b/src/github.com/matrix-org/dendrite/syncapi/storage/account_data_table.go index f95e48583..183e0d192 100644 --- a/src/github.com/matrix-org/dendrite/syncapi/storage/account_data_table.go +++ b/src/github.com/matrix-org/dendrite/syncapi/storage/account_data_table.go @@ -22,7 +22,7 @@ import ( const accountDataSchema = ` -- Stores the users account data -CREATE TABLE IF NOT EXISTS account_data_type ( +CREATE TABLE IF NOT EXISTS syncapi_account_data_type ( -- The highest numeric ID from the output_room_events at the time of saving the data id BIGINT, -- ID of the user the data belongs to @@ -35,19 +35,19 @@ CREATE TABLE IF NOT EXISTS account_data_type ( PRIMARY KEY(user_id, room_id, type), -- We don't want two entries of the same type for the same user - CONSTRAINT account_data_unique UNIQUE (user_id, room_id, type) + CONSTRAINT syncapi_account_data_unique UNIQUE (user_id, room_id, type) ); -CREATE UNIQUE INDEX IF NOT EXISTS account_data_id_idx ON account_data_type(id); +CREATE UNIQUE INDEX IF NOT EXISTS syncapi_account_data_id_idx ON syncapi_account_data_type(id); ` const insertAccountDataSQL = "" + - "INSERT INTO account_data_type (id, user_id, room_id, type) VALUES ($1, $2, $3, $4)" + - " ON CONFLICT ON CONSTRAINT account_data_unique" + + "INSERT INTO syncapi_account_data_type (id, user_id, room_id, type) VALUES ($1, $2, $3, $4)" + + " ON CONFLICT ON CONSTRAINT syncapi_account_data_unique" + " DO UPDATE SET id = EXCLUDED.id" const selectAccountDataInRangeSQL = "" + - "SELECT room_id, type FROM account_data_type" + + "SELECT room_id, type FROM syncapi_account_data_type" + " WHERE user_id = $1 AND id > $2 AND id <= $3" + " ORDER BY id ASC" diff --git a/src/github.com/matrix-org/dendrite/syncapi/storage/current_room_state_table.go b/src/github.com/matrix-org/dendrite/syncapi/storage/current_room_state_table.go index 64afaede8..9958e0d15 100644 --- a/src/github.com/matrix-org/dendrite/syncapi/storage/current_room_state_table.go +++ b/src/github.com/matrix-org/dendrite/syncapi/storage/current_room_state_table.go @@ -16,13 +16,14 @@ package storage import ( "database/sql" + "github.com/lib/pq" "github.com/matrix-org/gomatrixserverlib" ) const currentRoomStateSchema = ` -- Stores the current room state for every room. -CREATE TABLE IF NOT EXISTS current_room_state ( +CREATE TABLE IF NOT EXISTS syncapi_current_room_state ( -- The 'room_id' key for the state event. room_id TEXT NOT NULL, -- The state event ID @@ -40,37 +41,37 @@ CREATE TABLE IF NOT EXISTS current_room_state ( -- part of the current state of the room. added_at BIGINT, -- Clobber based on 3-uple of room_id, type and state_key - CONSTRAINT room_state_unique UNIQUE (room_id, type, state_key) + CONSTRAINT syncapi_room_state_unique UNIQUE (room_id, type, state_key) ); -- for event deletion -CREATE UNIQUE INDEX IF NOT EXISTS event_id_idx ON current_room_state(event_id); +CREATE UNIQUE INDEX IF NOT EXISTS syncapi_event_id_idx ON syncapi_current_room_state(event_id); -- for querying membership states of users -CREATE INDEX IF NOT EXISTS membership_idx ON current_room_state(type, state_key, membership) WHERE membership IS NOT NULL AND membership != 'leave'; +CREATE INDEX IF NOT EXISTS syncapi_membership_idx ON syncapi_current_room_state(type, state_key, membership) WHERE membership IS NOT NULL AND membership != 'leave'; ` const upsertRoomStateSQL = "" + - "INSERT INTO current_room_state (room_id, event_id, type, state_key, event_json, membership, added_at)" + + "INSERT INTO syncapi_current_room_state (room_id, event_id, type, state_key, event_json, membership, added_at)" + " VALUES ($1, $2, $3, $4, $5, $6, $7)" + - " ON CONFLICT ON CONSTRAINT room_state_unique" + + " ON CONFLICT ON CONSTRAINT syncapi_room_state_unique" + " DO UPDATE SET event_id = $2, event_json = $5, membership = $6, added_at = $7" const deleteRoomStateByEventIDSQL = "" + - "DELETE FROM current_room_state WHERE event_id = $1" + "DELETE FROM syncapi_current_room_state WHERE event_id = $1" const selectRoomIDsWithMembershipSQL = "" + - "SELECT room_id FROM current_room_state WHERE type = 'm.room.member' AND state_key = $1 AND membership = $2" + "SELECT room_id FROM syncapi_current_room_state WHERE type = 'm.room.member' AND state_key = $1 AND membership = $2" const selectCurrentStateSQL = "" + - "SELECT event_json FROM current_room_state WHERE room_id = $1" + "SELECT event_json FROM syncapi_current_room_state WHERE room_id = $1" const selectJoinedUsersSQL = "" + - "SELECT room_id, state_key FROM current_room_state WHERE type = 'm.room.member' AND membership = 'join'" + "SELECT room_id, state_key FROM syncapi_current_room_state WHERE type = 'm.room.member' AND membership = 'join'" const selectStateEventSQL = "" + - "SELECT event_json FROM current_room_state WHERE type = $1 AND room_id = $2 AND state_key = $3" + "SELECT event_json FROM syncapi_current_room_state WHERE type = $1 AND room_id = $2 AND state_key = $3" const selectEventsWithEventIDsSQL = "" + - "SELECT added_at, event_json FROM current_room_state WHERE event_id = ANY($1)" + "SELECT added_at, event_json FROM syncapi_current_room_state WHERE event_id = ANY($1)" type currentRoomStateStatements struct { upsertRoomStateStmt *sql.Stmt diff --git a/src/github.com/matrix-org/dendrite/syncapi/storage/output_room_events_table.go b/src/github.com/matrix-org/dendrite/syncapi/storage/output_room_events_table.go index 6c8a52635..f3c46298a 100644 --- a/src/github.com/matrix-org/dendrite/syncapi/storage/output_room_events_table.go +++ b/src/github.com/matrix-org/dendrite/syncapi/storage/output_room_events_table.go @@ -25,7 +25,7 @@ import ( const outputRoomEventsSchema = ` -- Stores output room events received from the roomserver. -CREATE TABLE IF NOT EXISTS output_room_events ( +CREATE TABLE IF NOT EXISTS syncapi_output_room_events ( -- An incrementing ID which denotes the position in the log that this event resides at. -- NB: 'serial' makes no guarantees to increment by 1 every time, only that it increments. -- This isn't a problem for us since we just want to order by this field. @@ -42,24 +42,29 @@ CREATE TABLE IF NOT EXISTS output_room_events ( remove_state_ids TEXT[] ); -- for event selection -CREATE UNIQUE INDEX IF NOT EXISTS event_id_idx ON output_room_events(event_id); +CREATE UNIQUE INDEX IF NOT EXISTS syncapi_event_id_idx ON syncapi_output_room_events(event_id); ` const insertEventSQL = "" + - "INSERT INTO output_room_events (room_id, event_id, event_json, add_state_ids, remove_state_ids) VALUES ($1, $2, $3, $4, $5) RETURNING id" + "INSERT INTO syncapi_output_room_events (" + + " room_id, event_id, event_json, add_state_ids, remove_state_ids" + + ") VALUES ($1, $2, $3, $4, $5) RETURNING id" const selectEventsSQL = "" + - "SELECT id, event_json FROM output_room_events WHERE event_id = ANY($1)" + "SELECT id, event_json FROM syncapi_output_room_events WHERE event_id = ANY($1)" const selectRecentEventsSQL = "" + - "SELECT id, event_json FROM output_room_events WHERE room_id = $1 AND id > $2 AND id <= $3 ORDER BY id DESC LIMIT $4" + "SELECT id, event_json FROM syncapi_output_room_events" + + " WHERE room_id = $1 AND id > $2 AND id <= $3" + + " ORDER BY id DESC LIMIT $4" const selectMaxIDSQL = "" + - "SELECT MAX(id) FROM output_room_events" + "SELECT MAX(id) FROM syncapi_output_room_events" // In order for us to apply the state updates correctly, rows need to be ordered in the order they were received (id). const selectStateInRangeSQL = "" + - "SELECT id, event_json, add_state_ids, remove_state_ids FROM output_room_events" + + "SELECT id, event_json, add_state_ids, remove_state_ids" + + " FROM syncapi_output_room_events" + " WHERE (id > $1 AND id <= $2) AND (add_state_ids IS NOT NULL OR remove_state_ids IS NOT NULL)" + " ORDER BY id ASC" diff --git a/src/github.com/matrix-org/dendrite/syncapi/storage/syncserver.go b/src/github.com/matrix-org/dendrite/syncapi/storage/syncserver.go index 2433b68cb..f7d5ebd7b 100644 --- a/src/github.com/matrix-org/dendrite/syncapi/storage/syncserver.go +++ b/src/github.com/matrix-org/dendrite/syncapi/storage/syncserver.go @@ -56,7 +56,7 @@ func NewSyncServerDatabase(dataSourceName string) (*SyncServerDatabase, error) { return nil, err } partitions := common.PartitionOffsetStatements{} - if err = partitions.Prepare(db); err != nil { + if err = partitions.Prepare(db, "syncapi"); err != nil { return nil, err } accountData := accountDataStatements{}