mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-21 13:53:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Comment generateMediaID

Browse source
This commit is contained in:
Neil Alexander 2020-08-25 14:46:22 +01:00
parent 0de3a2157b
commit 5306afd439
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
mediaapi/routing/upload.go
View file

@ -96,19 +96,27 @@ func parseAndValidateRequest(req *http.Request, cfg *config.MediaAPI) (*uploadRe
func (r *uploadRequest) generateMediaID(ctx context.Context, db storage.Database) (types.MediaID, error) { func (r *uploadRequest) generateMediaID(ctx context.Context, db storage.Database) (types.MediaID, error) {
for { for {
// First try generating a meda ID. We'll do this by
// generating some random bytes and then hex-encoding.
mediaIDBytes := make([]byte, 32) mediaIDBytes := make([]byte, 32)
_, err := rand.Read(mediaIDBytes) _, err := rand.Read(mediaIDBytes)
if err != nil { if err != nil {
return "", fmt.Errorf("rand.Read: %w", err) return "", fmt.Errorf("rand.Read: %w", err)
} }
mediaID := types.MediaID(hex.EncodeToString(mediaIDBytes)) mediaID := types.MediaID(hex.EncodeToString(mediaIDBytes))
// Then we will check if this media ID already exists in
// our database. If it does then we had best generate a
// new one.
existingMetadata, err := db.GetMediaMetadata(ctx, mediaID, r.MediaMetadata.Origin) existingMetadata, err := db.GetMediaMetadata(ctx, mediaID, r.MediaMetadata.Origin)
if err != nil { if err != nil {
return "", fmt.Errorf("db.GetMediaMetadata: %w", err) return "", fmt.Errorf("db.GetMediaMetadata: %w", err)
} }
if existingMetadata != nil { if existingMetadata != nil {
// The media ID was already used - repeat the process
// and generate a new one instead.
continue continue
} }
// The media ID was not already used - let's return that.
return mediaID, nil return mediaID, nil
} }
} }