From 560a90c3e044ca3c5884638569c4395a1aaa54a0 Mon Sep 17 00:00:00 2001 From: Kegan Dougal Date: Fri, 2 Oct 2020 16:28:56 +0100 Subject: [PATCH] Linting and remove another misleading check --- syncapi/routing/messages.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/syncapi/routing/messages.go b/syncapi/routing/messages.go index 1dd33dd62..9c6c6a80d 100644 --- a/syncapi/routing/messages.go +++ b/syncapi/routing/messages.go @@ -259,6 +259,7 @@ func (r *messagesReq) retrieveEvents() ( return clientEvents, start, end, err } +// nolint:gocyclo func (r *messagesReq) filterHistoryVisible(events []gomatrixserverlib.HeaderedEvent) []gomatrixserverlib.HeaderedEvent { // TODO FIXME: We don't fully implement history visibility yet. To avoid leaking events which the // user shouldn't see, we check the recent events and remove any prior to the join event of the user @@ -305,10 +306,6 @@ func (r *messagesReq) filterHistoryVisible(events []gomatrixserverlib.HeaderedEv wasJoined = false break } - if len(queryRes.StateEvents) == 0 { - wasJoined = false - break - } var hisVisEvent, membershipEvent *gomatrixserverlib.HeaderedEvent for i := range queryRes.StateEvents { switch queryRes.StateEvents[i].Type() {