mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-07 15:03:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

treat no sender ID as not joined to room in sendevent

Browse source 
- returning 403 forbidden instead of 404 not found
This commit is contained in:
Sam Wedgwood 2023-08-02 15:50:38 +01:00
parent ff18671fb0
commit 590d5a27ea
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
clientapi/routing/sendevent.go
View file

@ -316,11 +316,18 @@ func generateSendEvent(
} }
} }
senderID, err := rsAPI.QuerySenderIDForUser(ctx, *validRoomID, *fullUserID) senderID, err := rsAPI.QuerySenderIDForUser(ctx, *validRoomID, *fullUserID)
if err != nil || senderID == nil { if err != nil {
return nil, &util.JSONResponse{ return nil, &util.JSONResponse{
Code: http.StatusNotFound, Code: http.StatusNotFound,
JSON: spec.NotFound("Unable to find senderID for user"), JSON: spec.NotFound("Unable to find senderID for user"),
} }
} else if senderID == nil {
// TODO: is it always the case that lack of a sender ID means they're not joined?
// And should this logic be deferred to the roomserver somehow?
return nil, &util.JSONResponse{
Code: http.StatusForbidden,
JSON: spec.Forbidden("not joined to room"),
}
} }
// create the new event and set all the fields we can // create the new event and set all the fields we can