From 621326a5d6ec784eb1ae0dacfdac84bcb34b66cd Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Tue, 1 Nov 2022 13:54:59 +0100
Subject: [PATCH] Fix tests again

---
 roomserver/internal/query/query.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/roomserver/internal/query/query.go b/roomserver/internal/query/query.go
index b5f8d65ff..8850e5c46 100644
--- a/roomserver/internal/query/query.go
+++ b/roomserver/internal/query/query.go
@@ -255,9 +255,9 @@ func (r *Queryer) QueryMembershipAtEvent(
 	}
 
 	var memberships []types.Event
-	for i, eventID := range request.EventIDs {
+	for _, eventID := range request.EventIDs {
 		stateEntry, ok := stateEntries[eventID]
-		if !ok {
+		if !ok || len(stateEntry) == 0 {
 			response.Memberships[eventID] = []*gomatrixserverlib.HeaderedEvent{}
 			continue
 		}
@@ -265,7 +265,7 @@ func (r *Queryer) QueryMembershipAtEvent(
 		// If we can short circuit, e.g. we only have 0 or 1 membership events, we only get the memberships
 		// once. If we have more than one membership event, we need to get the state for each state entry.
 		if canShortCircuit {
-			if i == 0 {
+			if len(memberships) == 0 {
 				memberships, err = helpers.GetMembershipsAtState(ctx, r.DB, stateEntry, false)
 			}
 		} else {