From 63f3bfa8b38282cec4a8d66cb17bccc2e82b173d Mon Sep 17 00:00:00 2001
From: Kegan Dougal <kegan@matrix.org>
Date: Wed, 13 May 2020 11:52:22 +0100
Subject: [PATCH] Review comments and linting

---
 syncapi/sync/notifier_test.go | 1 -
 syncapi/types/types.go        | 8 ++++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/syncapi/sync/notifier_test.go b/syncapi/sync/notifier_test.go
index ce1214319..7d979fcc9 100644
--- a/syncapi/sync/notifier_test.go
+++ b/syncapi/sync/notifier_test.go
@@ -33,7 +33,6 @@ var (
 	randomMessageEvent  gomatrixserverlib.HeaderedEvent
 	aliceInviteBobEvent gomatrixserverlib.HeaderedEvent
 	bobLeaveEvent       gomatrixserverlib.HeaderedEvent
-	baseSyncPos         = types.NewStreamToken(0, 0)
 	syncPositionVeryOld = types.NewStreamToken(5, 0)
 	syncPositionBefore  = types.NewStreamToken(11, 0)
 	syncPositionAfter   = types.NewStreamToken(12, 0)
diff --git a/syncapi/types/types.go b/syncapi/types/types.go
index 86f527875..c1b6d7dd5 100644
--- a/syncapi/types/types.go
+++ b/syncapi/types/types.go
@@ -189,6 +189,10 @@ func NewTopologyTokenFromString(tok string) (token TopologyToken, err error) {
 		err = fmt.Errorf("token %s is not a topology token", tok)
 		return
 	}
+	if len(t.Positions) != 2 {
+		err = fmt.Errorf("token %s wrong number of values, got %d want 2", tok, len(t.Positions))
+		return
+	}
 	return TopologyToken{
 		syncToken: *t,
 	}, nil
@@ -212,6 +216,10 @@ func NewStreamTokenFromString(tok string) (token StreamingToken, err error) {
 		err = fmt.Errorf("token %s is not a streaming token", tok)
 		return
 	}
+	if len(t.Positions) != 2 {
+		err = fmt.Errorf("token %s wrong number of values, got %d want 2", tok, len(t.Positions))
+		return
+	}
 	return StreamingToken{
 		syncToken: *t,
 	}, nil