Don't skip cert validation on appservices, fix logging

src/github.com/matrix-org/dendrite/appservice/query/query.go

@@ -77,7 +77,7 @@ func (a *AppServiceQueryAPI) RoomAliasExists(
 						log.WithFields(log.Fields{
 							"appservice_id": appservice.ID,
 							"status_code":   resp.StatusCode,
-						}).Error("Unable to close application service response body")
+						}).WithError(err).Error("Unable to close application service response body")
 					}
 				}()
 			}
@@ -107,12 +107,6 @@ func (a *AppServiceQueryAPI) RoomAliasExists(
 func makeHTTPClient() *http.Client {
 	return &http.Client{
 		Timeout: time.Second * 30,
-		// TODO: Verify certificates
-		Transport: &http.Transport{
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: true, // nolint: gas
-			},
-		},
 	}
 }
 

src/github.com/matrix-org/dendrite/appservice/workers/transaction_scheduler.go

@@ -68,12 +68,6 @@ func worker(db *storage.Database, ws types.ApplicationServiceWorkerState) {
 	// Create a HTTP client for sending requests to app services
 	client := &http.Client{
 		Timeout: transactionTimeout,
-		// TODO: Verify certificates
-		Transport: &http.Transport{
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: true, // nolint: gas
-			},
-		},
 	}
 
 	// Initial check for any leftover events to send from last time