mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-15 19:03:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't skip cert validation on appservices, fix logging

Browse source
This commit is contained in:
user 2018-08-06 16:45:19 +01:00
parent a9465ad36c
commit 6d0cba84e8
2 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/github.com/matrix-org/dendrite/appservice/query/query.go
View file

@ -77,7 +77,7 @@ func (a *AppServiceQueryAPI) RoomAliasExists(
log.WithFields(log.Fields{ log.WithFields(log.Fields{
"appservice_id": appservice.ID, "appservice_id": appservice.ID,
"status_code": resp.StatusCode, "status_code": resp.StatusCode,
}).Error("Unable to close application service response body") }).WithError(err).Error("Unable to close application service response body")
} }
}() }()
} }
@ -107,12 +107,6 @@ func (a *AppServiceQueryAPI) RoomAliasExists(
func makeHTTPClient() *http.Client { func makeHTTPClient() *http.Client {
return &http.Client{ return &http.Client{
Timeout: time.Second * 30, Timeout: time.Second * 30,
// TODO: Verify certificates
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true, // nolint: gas
},
},
} }
} }

6
src/github.com/matrix-org/dendrite/appservice/workers/transaction_scheduler.go
View file

@ -68,12 +68,6 @@ func worker(db *storage.Database, ws types.ApplicationServiceWorkerState) {
// Create a HTTP client for sending requests to app services // Create a HTTP client for sending requests to app services
client := &http.Client{ client := &http.Client{
Timeout: transactionTimeout, Timeout: transactionTimeout,
// TODO: Verify certificates
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true, // nolint: gas
},
},
} }
// Initial check for any leftover events to send from last time // Initial check for any leftover events to send from last time