mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-01 03:03:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't refresh notifier, use the memberships from the join response instead so that it doesn't load presence for members we are ommitting due to LL

Browse source
This commit is contained in:
Neil Alexander 2022-04-26 14:38:45 +01:00
parent 9d34f9738c
commit 7143ef20a1
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
1 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
syncapi/streams/stream_presence.go
View file

@ -87,22 +87,27 @@ func (p *PresenceStreamProvider) populatePresence(
ignoreCache bool,
) error {
// add newly joined rooms user presences
newlyJoined := joinedRooms(req.Response, req.Device.UserID)
if len(newlyJoined) > 0 {
// TODO: This refreshes all lists and is quite expensive
// The notifier should update the lists itself
if err := p.notifier.Load(ctx, p.DB); err != nil {
return err
}
if newlyJoined := joinedRooms(req.Response, req.Device.UserID); len(newlyJoined) > 0 {
for _, roomID := range newlyJoined {
roomUsers := p.notifier.JoinedUsers(roomID)
for i := range roomUsers {
// we already got a presence from this user
if _, ok := presences[roomUsers[i]]; ok {
room, ok := req.Response.Rooms.Join[roomID]
if !ok {
continue
}
for _, stateEvent := range room.State.Events {
switch {
case stateEvent.Type != gomatrixserverlib.MRoomMember:
fallthrough
case stateEvent.StateKey == nil:
fallthrough
case *stateEvent.StateKey == "":
continue
}
userID := *stateEvent.StateKey
if _, ok := presences[userID]; ok {
continue
}
var err error
presences[roomUsers[i]], err = p.DB.GetPresence(ctx, roomUsers[i])
presences[userID], err = p.DB.GetPresence(ctx, userID)
if err != nil {
if err == sql.ErrNoRows {
continue