From 78ebf6f7ababc4bb195f6b0bc42abbefa6adb701 Mon Sep 17 00:00:00 2001
From: Till Faelligen <davidf@element.io>
Date: Mon, 9 May 2022 14:28:12 +0200
Subject: [PATCH] Test what happens if we select non-existing NIDs

---
 .../storage/tables/event_json_table_test.go   | 47 ++++++++++++++++---
 1 file changed, 40 insertions(+), 7 deletions(-)

diff --git a/roomserver/storage/tables/event_json_table_test.go b/roomserver/storage/tables/event_json_table_test.go
index cb00aac00..b490d0fe8 100644
--- a/roomserver/storage/tables/event_json_table_test.go
+++ b/roomserver/storage/tables/event_json_table_test.go
@@ -42,6 +42,7 @@ func Test_EventJSONTable(t *testing.T) {
 	test.WithAllDatabases(t, func(t *testing.T, dbType test.DBType) {
 		tab, close := mustCreateEventJSONTable(t, dbType)
 		defer close()
+
 		// create some dummy data
 		for i := 0; i < 10; i++ {
 			err := tab.InsertEventJSON(
@@ -50,13 +51,45 @@ func Test_EventJSONTable(t *testing.T) {
 			)
 			assert.NoError(t, err)
 		}
-		// select a subset of the data
-		values, err := tab.BulkSelectEventJSON(context.Background(), nil, []types.EventNID{1, 2, 3, 4, 5})
-		assert.NoError(t, err)
-		assert.Equal(t, 5, len(values))
-		for i, v := range values {
-			assert.Equal(t, v.EventNID, types.EventNID(i+1))
-			assert.Equal(t, []byte(fmt.Sprintf(`{"value":%d"}`, i+1)), v.EventJSON)
+
+		tests := []struct {
+			name      string
+			args      []types.EventNID
+			wantCount int
+		}{
+			{
+				name:      "select subset of existing NIDs",
+				args:      []types.EventNID{1, 2, 3, 4, 5},
+				wantCount: 5,
+			},
+			{
+				name:      "select subset of existing/non-existing NIDs",
+				args:      []types.EventNID{1, 2, 12, 50},
+				wantCount: 2,
+			},
+			{
+				name:      "select single existing NID",
+				args:      []types.EventNID{1},
+				wantCount: 1,
+			},
+			{
+				name:      "select single non-existing NID",
+				args:      []types.EventNID{13},
+				wantCount: 0,
+			},
+		}
+
+		for _, tc := range tests {
+			t.Run(tc.name, func(t *testing.T) {
+				// select a subset of the data
+				values, err := tab.BulkSelectEventJSON(context.Background(), nil, tc.args)
+				assert.NoError(t, err)
+				assert.Equal(t, tc.wantCount, len(values))
+				for i, v := range values {
+					assert.Equal(t, v.EventNID, types.EventNID(i+1))
+					assert.Equal(t, []byte(fmt.Sprintf(`{"value":%d"}`, i+1)), v.EventJSON)
+				}
+			})
 		}
 	})
 }