From 7da9f779720aa6f54d18afe082fad6bee2eb0a97 Mon Sep 17 00:00:00 2001 From: Brian Meek Date: Thu, 28 Jul 2022 09:20:42 -0700 Subject: [PATCH] Fix race detected by golang race detector in stream_pdu, reusing an err variable across go routines Signed-off-by: Brian Meek --- syncapi/streams/stream_pdu.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/syncapi/streams/stream_pdu.go b/syncapi/streams/stream_pdu.go index 00b3dfe3b..4d7176961 100644 --- a/syncapi/streams/stream_pdu.go +++ b/syncapi/streams/stream_pdu.go @@ -109,8 +109,7 @@ func (p *PDUStreamProvider) CompleteSync( p.queue(func() { defer reqWaitGroup.Done() - var jr *types.JoinResponse - jr, err = p.getJoinResponseForCompleteSync( + jr, err := p.getJoinResponseForCompleteSync( ctx, roomID, r, &stateFilter, &eventFilter, req.WantFullState, req.Device, ) if err != nil {