diff --git a/roomserver/internal/input_latest_events.go b/roomserver/internal/input_latest_events.go index 66316ac4f..988b3e7dd 100644 --- a/roomserver/internal/input_latest_events.go +++ b/roomserver/internal/input_latest_events.go @@ -92,7 +92,7 @@ func (r *RoomserverInternalAPI) updateLatestEvents( type latestEventsUpdater struct { ctx context.Context api *RoomserverInternalAPI - updater types.RoomRecentEventsUpdater + updater types.LatestEventsUpdater roomNID types.RoomNID stateAtEvent types.StateAtEvent event gomatrixserverlib.Event diff --git a/roomserver/internal/input_membership.go b/roomserver/internal/input_membership.go index af0c7f8b3..8fc69de8f 100644 --- a/roomserver/internal/input_membership.go +++ b/roomserver/internal/input_membership.go @@ -29,7 +29,7 @@ import ( // consumers about the invites added or retired by the change in current state. func (r *RoomserverInternalAPI) updateMemberships( ctx context.Context, - updater types.RoomRecentEventsUpdater, + updater types.LatestEventsUpdater, removed, added []types.StateEntry, ) ([]api.OutputEvent, error) { changes := membershipChanges(removed, added) @@ -77,7 +77,7 @@ func (r *RoomserverInternalAPI) updateMemberships( } func (r *RoomserverInternalAPI) updateMembership( - updater types.RoomRecentEventsUpdater, + updater types.LatestEventsUpdater, targetUserNID types.EventStateKeyNID, remove, add *gomatrixserverlib.Event, updates []api.OutputEvent, diff --git a/roomserver/storage/interface.go b/roomserver/storage/interface.go index afe5bcb1f..32fccc7fe 100644 --- a/roomserver/storage/interface.go +++ b/roomserver/storage/interface.go @@ -86,7 +86,7 @@ type Database interface { // The RoomRecentEventsUpdater must have Commit or Rollback called on it if this doesn't return an error. // Returns the latest events in the room and the last eventID sent to the log along with an updater. // If this returns an error then no further action is required. - GetLatestEventsForUpdate(ctx context.Context, roomNID types.RoomNID) (types.RoomRecentEventsUpdater, error) + GetLatestEventsForUpdate(ctx context.Context, roomNID types.RoomNID) (types.LatestEventsUpdater, error) // Look up event ID by transaction's info. // This is used to determine if the room event is processed/processing already. // Returns an empty string if no such event exists. diff --git a/roomserver/storage/shared/latest_events_updater.go b/roomserver/storage/shared/latest_events_updater.go index 03ced35af..92f87ec18 100644 --- a/roomserver/storage/shared/latest_events_updater.go +++ b/roomserver/storage/shared/latest_events_updater.go @@ -17,7 +17,7 @@ type latestEventsUpdater struct { currentStateSnapshotNID types.StateSnapshotNID } -func NewLatestEventsUpdater(ctx context.Context, d *Database, txn *sql.Tx, roomNID types.RoomNID) (types.RoomRecentEventsUpdater, error) { +func NewLatestEventsUpdater(ctx context.Context, d *Database, txn *sql.Tx, roomNID types.RoomNID) (types.LatestEventsUpdater, error) { eventNIDs, lastEventNIDSent, currentStateSnapshotNID, err := d.RoomsTable.SelectLatestEventsNIDsForUpdate(ctx, txn, roomNID) if err != nil { diff --git a/roomserver/storage/shared/storage.go b/roomserver/storage/shared/storage.go index 67f7f5fb0..9825d2723 100644 --- a/roomserver/storage/shared/storage.go +++ b/roomserver/storage/shared/storage.go @@ -342,7 +342,7 @@ func (d *Database) MembershipUpdater( func (d *Database) GetLatestEventsForUpdate( ctx context.Context, roomNID types.RoomNID, -) (types.RoomRecentEventsUpdater, error) { +) (types.LatestEventsUpdater, error) { txn, err := d.DB.Begin() if err != nil { return nil, err diff --git a/roomserver/storage/sqlite3/storage.go b/roomserver/storage/sqlite3/storage.go index e66ca1037..4a564d69e 100644 --- a/roomserver/storage/sqlite3/storage.go +++ b/roomserver/storage/sqlite3/storage.go @@ -139,7 +139,7 @@ func Open(dbProperties *config.DatabaseOptions) (*Database, error) { func (d *Database) GetLatestEventsForUpdate( ctx context.Context, roomNID types.RoomNID, -) (types.RoomRecentEventsUpdater, error) { +) (types.LatestEventsUpdater, error) { // TODO: Do not use transactions. We should be holding open this transaction but we cannot have // multiple write transactions on sqlite. The code will perform additional // write transactions independent of this one which will consistently cause diff --git a/roomserver/types/types.go b/roomserver/types/types.go index 241e1e15d..c2a37764d 100644 --- a/roomserver/types/types.go +++ b/roomserver/types/types.go @@ -140,10 +140,10 @@ type StateEntryList struct { StateEntries []StateEntry } -// A RoomRecentEventsUpdater is used to update the recent events in a room. +// A LatestEventsUpdater is used to update the recent events in a room. // (On postgresql this wraps a database transaction that holds a "FOR UPDATE" // lock on the row in the rooms table holding the latest events for the room.) -type RoomRecentEventsUpdater interface { +type LatestEventsUpdater interface { // The room version of the room. RoomVersion() gomatrixserverlib.RoomVersion // The latest event IDs and state in the room.