From 84beb42182c443fa2718e2dbc9b25db2fcdd2453 Mon Sep 17 00:00:00 2001 From: Neil Alexander Date: Tue, 23 Aug 2022 13:42:32 +0100 Subject: [PATCH] Allow requesting outliers with no state --- roomserver/internal/helpers/helpers.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/roomserver/internal/helpers/helpers.go b/roomserver/internal/helpers/helpers.go index e4d4735ef..cbd1561f7 100644 --- a/roomserver/internal/helpers/helpers.go +++ b/roomserver/internal/helpers/helpers.go @@ -256,9 +256,9 @@ func CheckServerAllowedToSeeEvent( default: switch err.(type) { case types.MissingStateError: - // TODO: This may prevent other servers from requesting outliers from us. - // Is this the right thing to do? - return false, nil + // If there's no state then we assume it's open visibility, as Synapse does: + // https://github.com/matrix-org/synapse/blob/aec87a0f9369a3015b2a53469f88d1de274e8b71/synapse/visibility.py#L654-L655 + return true, nil default: // Something else went wrong return false, err