mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-02-22 02:44:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't hold lock while sending transaction

Browse source
This commit is contained in:
Neil Alexander 2020-12-07 11:43:35 +00:00
parent 36356ac8d1
commit 8861f907ed
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
federationsender/queue/destinationqueue.go
View file

@ -279,11 +279,13 @@ func (oq *destinationQueue) backgroundSend() {
if eduCount > maxEDUsPerTransaction { if eduCount > maxEDUsPerTransaction {
eduCount = maxEDUsPerTransaction eduCount = maxEDUsPerTransaction
} }
toSendPDUs := oq.pendingPDUs[:pduCount]
toSendEDUs := oq.pendingEDUs[:eduCount]
oq.pendingMutex.RUnlock()
// If we have pending PDUs or EDUs then construct a transaction. // If we have pending PDUs or EDUs then construct a transaction.
// Try sending the next transaction and see what happens. // Try sending the next transaction and see what happens.
transaction, pc, ec, terr := oq.nextTransaction(oq.pendingPDUs[:pduCount], oq.pendingEDUs[:eduCount]) transaction, pc, ec, terr := oq.nextTransaction(toSendPDUs, toSendEDUs)
oq.pendingMutex.RUnlock()
if terr != nil { if terr != nil {
// We failed to send the transaction. Mark it as a failure. // We failed to send the transaction. Mark it as a failure.
oq.statistics.Failure() oq.statistics.Failure()