From 88b3e0c1587d2912ae4cfe9842b3cb15b75dd3d5 Mon Sep 17 00:00:00 2001 From: Till Faelligen <2353100+S7evinK@users.noreply.github.com> Date: Fri, 11 Nov 2022 10:44:28 +0100 Subject: [PATCH] Log error about missing/unable to get m.room.guest_access event --- roomserver/internal/perform/perform_join.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/roomserver/internal/perform/perform_join.go b/roomserver/internal/perform/perform_join.go index 57a9e445b..e291b461e 100644 --- a/roomserver/internal/perform/perform_join.go +++ b/roomserver/internal/perform/perform_join.go @@ -16,6 +16,7 @@ package perform import ( "context" + "database/sql" "errors" "fmt" "strings" @@ -276,7 +277,10 @@ func (r *Joiner) performJoinRoomByID( var guestAccessEvent *gomatrixserverlib.HeaderedEvent guestAccess := "forbidden" guestAccessEvent, err = r.DB.GetStateEvent(ctx, req.RoomIDOrAlias, gomatrixserverlib.MRoomGuestAccess, "") - if err == nil && guestAccessEvent != nil { + if (err != nil && !errors.Is(err, sql.ErrNoRows)) || guestAccessEvent == nil { + logrus.WithError(err).Warn("unable to get m.room.guest_access event, defaulting to 'forbidden'") + } + if guestAccessEvent != nil { guestAccess = gjson.GetBytes(guestAccessEvent.Content(), "guest_access").String() }