Review comments

This commit is contained in:
Kegan Dougal 2020-04-17 12:08:04 +01:00
parent 0c024d94bd
commit 8d04b528b1
2 changed files with 8 additions and 10 deletions

View file

@ -48,6 +48,7 @@ func InitialPowerLevelsContent(roomCreator string) (c gomatrixserverlib.PowerLev
"m.room.history_visibility": 100, "m.room.history_visibility": 100,
"m.room.canonical_alias": 50, "m.room.canonical_alias": 50,
"m.room.avatar": 50, "m.room.avatar": 50,
"m.room.aliases": 0, // anyone can publish aliases by default. Has to be 0 else state_default is used.
} }
c.Users = map[string]int64{roomCreator: 100} c.Users = map[string]int64{roomCreator: 100}
return c return c

View file

@ -94,16 +94,13 @@ func SetVisibility(
} }
// NOTSPEC: Check if the user's power is greater than power required to change m.room.aliases event // NOTSPEC: Check if the user's power is greater than power required to change m.room.aliases event
// p2p relies on anyone being able to publish rooms. power, _ := gomatrixserverlib.NewPowerLevelContentFromEvent(queryEventsRes.StateEvents[0].Event)
/* if power.UserLevel(dev.UserID) < power.EventLevel(gomatrixserverlib.MRoomAliases, true) {
power, _ := gomatrixserverlib.NewPowerLevelContentFromEvent(queryEventsRes.StateEvents[0].Event) return util.JSONResponse{
if power.UserLevel(dev.UserID) < power.EventLevel(gomatrixserverlib.MRoomAliases, true) { Code: http.StatusForbidden,
return util.JSONResponse{ JSON: jsonerror.Forbidden("userID doesn't have power level to change visibility"),
Code: http.StatusForbidden, }
JSON: jsonerror.Forbidden("userID doesn't have power level to change visibility"), }
}
}
*/
var v roomVisibility var v roomVisibility
if reqErr := httputil.UnmarshalJSONRequest(req, &v); reqErr != nil { if reqErr := httputil.UnmarshalJSONRequest(req, &v); reqErr != nil {