mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-05 13:13:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Only force a notifier update if we have to

Browse source
This commit is contained in:
Neil Alexander 2022-04-26 16:24:09 +01:00
parent 9f155c8f97
commit 8e1b5abd1b
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
syncapi/streams/stream_presence.go
View file

@ -87,6 +87,7 @@ func (p *PresenceStreamProvider) populatePresence(
presences map[string]*types.PresenceInternal, presences map[string]*types.PresenceInternal,
ignoreCache bool, ignoreCache bool,
) error { ) error {
var changesMade bool
for _, room := range req.Response.Rooms.Join { for _, room := range req.Response.Rooms.Join {
for _, stateEvent := range append(room.State.Events, room.Timeline.Events...) { for _, stateEvent := range append(room.State.Events, room.Timeline.Events...) {
switch { switch {
@ -108,14 +109,18 @@ func (p *PresenceStreamProvider) populatePresence(
if err != nil && err != sql.ErrNoRows { if err != nil && err != sql.ErrNoRows {
return err return err
} }
changesMade = true
} }
} }
// TODO: This is expensive, why do we do this? if changesMade {
// TODO: This is expensive, but seems to be the only thing that
// stops sytest from racing on a couple of remote user tests.
if err := p.notifier.Load(ctx, p.DB); err != nil { if err := p.notifier.Load(ctx, p.DB); err != nil {
req.Log.WithError(err).Error("unable to refresh notifier lists") req.Log.WithError(err).Error("unable to refresh notifier lists")
return err return err
} }
}
for _, presence := range presences { for _, presence := range presences {
// Ignore users we don't share a room with // Ignore users we don't share a room with