From 8f5eb0c9046280219a88c8bbf8eb541e912b4313 Mon Sep 17 00:00:00 2001
From: Kegan Dougal <kegan@matrix.org>
Date: Mon, 8 Mar 2021 17:52:59 +0000
Subject: [PATCH] delete properly

---
 roomserver/internal/perform/perform_join.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/roomserver/internal/perform/perform_join.go b/roomserver/internal/perform/perform_join.go
index 4a7abbd44..6eaaec230 100644
--- a/roomserver/internal/perform/perform_join.go
+++ b/roomserver/internal/perform/perform_join.go
@@ -153,10 +153,11 @@ func (r *Joiner) performJoinRoomByID(
 ) (string, gomatrixserverlib.ServerName, error) {
 	// The original client request ?server_name=... may include this HS so filter that out so we
 	// don't attempt to make_join with ourselves
-	for i, srv := range req.ServerNames {
-		if srv == r.Cfg.Matrix.ServerName {
+	for i := 0; i < len(req.ServerNames); i++ {
+		if req.ServerNames[i] == r.Cfg.Matrix.ServerName {
 			// delete this entry
 			req.ServerNames = append(req.ServerNames[:i], req.ServerNames[i+1:]...)
+			i--
 		}
 	}