Update tests

internal/sqlutil/migrate_test.go

@@ -8,6 +8,7 @@ import (
 	"testing"
 
 	"github.com/matrix-org/dendrite/internal/sqlutil"
+	"github.com/matrix-org/dendrite/test"
 	_ "github.com/mattn/go-sqlite3"
 )
 
@@ -55,23 +56,17 @@ var failMigration = sqlutil.Migration{
 }
 
 func Test_migrations_Up(t *testing.T) {
-	withFail := make([]sqlutil.Migration, len(dummyMigrations))
+	withFail := append(dummyMigrations, failMigration)
-	copy(withFail, dummyMigrations)
-	withFail = append(withFail, failMigration)
 
 	tests := []struct {
 		name       string
-		connectionString string
-		ctx              context.Context
 		migrations []sqlutil.Migration
 		wantResult map[string]bool
 		wantErr    bool
 	}{
 		{
 			name:       "dummy migration",
-			connectionString: "file::memory:",
 			migrations: dummyMigrations,
-			ctx:              context.Background(),
 			wantResult: map[string]bool{
 				"init":           true,
 				"v2":             true,
@@ -80,25 +75,31 @@ func Test_migrations_Up(t *testing.T) {
 		},
 		{
 			name:       "with fail",
-			connectionString: "file::memory:",
 			migrations: withFail,
-			ctx:              context.Background(),
 			wantErr:    true,
 		},
 	}
 
+	ctx := context.Background()
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			db, err := sql.Open("sqlite3", tt.connectionString)
+			test.WithAllDatabases(t, func(t *testing.T, dbType test.DBType) {
+				conStr, close := test.PrepareDBConnectionString(t, dbType)
+				defer close()
+				driverName := "sqlite3"
+				if dbType == test.DBTypePostgres {
+					driverName = "postgres"
+				}
+				db, err := sql.Open(driverName, conStr)
 				if err != nil {
 					t.Errorf("unable to open database: %v", err)
 				}
 				m := sqlutil.NewMigrator(db)
 				m.AddMigrations(tt.migrations...)
-			if err = m.Up(tt.ctx); (err != nil) != tt.wantErr {
+				if err = m.Up(ctx); (err != nil) != tt.wantErr {
 					t.Errorf("Up() error = %v, wantErr %v", err, tt.wantErr)
 				}
-			result, err := m.ExecutedMigrations(tt.ctx)
+				result, err := m.ExecutedMigrations(ctx)
 				if err != nil {
 					t.Errorf("unable to get executed migrations: %v", err)
 				}
@@ -106,5 +107,6 @@ func Test_migrations_Up(t *testing.T) {
 					t.Errorf("expected: %+v, got %v", tt.wantResult, result)
 				}
 			})
+		})
 	}
 }