mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-21 05:43:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Try to limit wakeups

Browse source
This commit is contained in:
Neil Alexander 2020-07-01 10:48:57 +01:00
parent 4cc1eaac5a
commit 9ef7147772
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
federationsender/queue/destinationqueue.go
View file

@ -118,9 +118,11 @@ func (oq *destinationQueue) sendEvent(nid int64) {
go oq.backgroundSend() go oq.backgroundSend()
} }
// Signal that we've sent a new PDU. This will cause the queue to // Signal that we've sent a new PDU. This will cause the queue to
// wake up if it's asleep. // wake up if it's asleep. The return to the Add function will only
oq.pendingPDUs.Add(1) // be 1 if the previous value was 0, e.g. nothing was waiting before.
oq.wakeServerCh <- true if oq.pendingPDUs.Add(1) == 1 {
oq.wakeServerCh <- true
}
} }
// sendEDU adds the EDU event to the pending queue for the destination. // sendEDU adds the EDU event to the pending queue for the destination.
@ -167,10 +169,11 @@ func (oq *destinationQueue) backgroundSend() {
// PDUs in the database. Otherwise we'll generate one later on, // PDUs in the database. Otherwise we'll generate one later on,
// e.g. in response to EDUs. // e.g. in response to EDUs.
transactionID := gomatrixserverlib.TransactionID("") transactionID := gomatrixserverlib.TransactionID("")
pendingPDUs := oq.pendingPDUs.Load()
// If we have nothing to do then wait either for incoming events, or // If we have nothing to do then wait either for incoming events, or
// until we hit an idle timeout. // until we hit an idle timeout.
if oq.pendingPDUs.Load() == 0 { if pendingPDUs == 0 {
select { select {
case <-oq.wakeServerCh: case <-oq.wakeServerCh:
// We were woken up because there are new PDUs waiting in the // We were woken up because there are new PDUs waiting in the
@ -225,7 +228,7 @@ func (oq *destinationQueue) backgroundSend() {
} }
// If we have pending PDUs or EDUs then construct a transaction. // If we have pending PDUs or EDUs then construct a transaction.
if oq.pendingPDUs.Load() > 0 || len(oq.pendingEDUs) > 0 { if pendingPDUs > 0 || len(oq.pendingEDUs) > 0 {
// If we haven't got a transaction ID then we should generate // If we haven't got a transaction ID then we should generate
// one. Ideally we'd know this already because something queued // one. Ideally we'd know this already because something queued
// in the database would give us one, but if we're dealing with // in the database would give us one, but if we're dealing with