Refine SenderID/UserID usage

This commit is contained in:
Devon Hudson 2023-06-02 19:37:08 -06:00
parent 7cf96a865d
commit b324f7eccc
No known key found for this signature in database
GPG key ID: CD06B18E77F6A628

View file

@ -615,7 +615,12 @@ func (s *OutputRoomEventConsumer) notifyLocal(ctx context.Context, event *rstype
// evaluatePushRules fetches and evaluates the push rules of a local
// user. Returns actions (including dont_notify).
func (s *OutputRoomEventConsumer) evaluatePushRules(ctx context.Context, event *rstypes.HeaderedEvent, mem *localMembership, roomSize int) ([]*pushrules.Action, error) {
if event.SenderID() == mem.UserID {
user := ""
userID, err := event.UserID()
if err == nil {
user = userID.String()
}
if user == mem.UserID {
// SPEC: Homeservers MUST NOT notify the Push Gateway for
// events that the user has sent themselves.
return nil, nil
@ -767,7 +772,7 @@ func (s *OutputRoomEventConsumer) notifyHTTP(ctx context.Context, event *rstypes
ID: event.EventID(),
RoomID: event.RoomID(),
RoomName: roomName,
Sender: event.SenderID(),
Sender: event.SenderID(), // TODO: Should push use UserIDs?
Type: event.Type(),
},
}