From b4ff83bd965bfdae3740587927f22c7e6caa2210 Mon Sep 17 00:00:00 2001 From: Tak Wai Wong <64229756+tak-hntlabs@users.noreply.github.com> Date: Tue, 9 Aug 2022 14:51:56 -0700 Subject: [PATCH] Remove nonce generation for eip4361 signin (#25) Co-authored-by: Tak Wai Wong --- clientapi/auth/login_publickey_test.go | 2 -- clientapi/routing/register_publickey_test.go | 1 - 2 files changed, 3 deletions(-) diff --git a/clientapi/auth/login_publickey_test.go b/clientapi/auth/login_publickey_test.go index 321d8eb6c..6b95c5553 100644 --- a/clientapi/auth/login_publickey_test.go +++ b/clientapi/auth/login_publickey_test.go @@ -61,7 +61,6 @@ func TestLoginPublicKeyNewSession(t *testing.T) { "err.Code actual: %v, expected: %v", err.Code, http.StatusUnauthorized) challenge := err.JSON.(Challenge) assert.NotEmptyf(challenge.Session, "challenge.Session") - assert.NotEmptyf(challenge.Completed, "challenge.Completed") assert.Truef( authtypes.LoginTypePublicKeyEthereum == challenge.Flows[0].Stages[0], "challenge.Flows[0].Stages[0] actual: %v, expected: %v", challenge.Flows[0].Stages[0], authtypes.LoginTypePublicKeyEthereum) @@ -74,7 +73,6 @@ func TestLoginPublicKeyNewSession(t *testing.T) { "[object]") ethParams := params.(config.EthereumAuthParams) assert.NotEmptyf(ethParams.ChainIDs, "ChainIDs actual: empty, expected not empty") - assert.NotEmptyf(ethParams.Nonce, "Nonce actual: \"\", expected: not empty") assert.NotEmptyf(ethParams.Version, "Version actual: \"\", expected: not empty") } diff --git a/clientapi/routing/register_publickey_test.go b/clientapi/routing/register_publickey_test.go index c51ee1846..4079669b9 100644 --- a/clientapi/routing/register_publickey_test.go +++ b/clientapi/routing/register_publickey_test.go @@ -340,7 +340,6 @@ func TestNewRegistrationSession(t *testing.T) { "[object]") ethParams := params.(config.EthereumAuthParams) assert.NotEmptyf(ethParams.ChainIDs, "ChainIDs actual: empty, expected not empty") - assert.NotEmptyf(ethParams.Nonce, "Nonce actual: \"\", expected: not empty") assert.NotEmptyf(ethParams.Version, "Version actual: \"\", expected: not empty") }