From ba389838881b3de325fbad68c6d849e5cceca9af Mon Sep 17 00:00:00 2001 From: Till Faelligen <2353100+S7evinK@users.noreply.github.com> Date: Mon, 17 Oct 2022 15:02:30 +0200 Subject: [PATCH] Update comments --- syncapi/storage/tables/memberships_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/syncapi/storage/tables/memberships_test.go b/syncapi/storage/tables/memberships_test.go index b128279e1..0cee7f5a5 100644 --- a/syncapi/storage/tables/memberships_test.go +++ b/syncapi/storage/tables/memberships_test.go @@ -110,8 +110,6 @@ func testHeroes(t *testing.T, ctx context.Context, table tables.Memberships, use for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { - - // no membership queried got, err := table.SelectHeroes(ctx, nil, room.ID, user.ID, tc.memberships) if err != nil { t.Fatalf("unable to select heroes: %s", err) @@ -129,7 +127,7 @@ func testHeroes(t *testing.T, ctx context.Context, table tables.Memberships, use func testMembershipCount(t *testing.T, ctx context.Context, table tables.Memberships, room *test.Room) { t.Run("membership counts are correct", func(t *testing.T) { - // After 10 events, we should have 6 users + // After 10 events, we should have 6 users (5 create related [incl. one member event], 5 member events = 6 users) count, err := table.SelectMembershipCount(ctx, nil, room.ID, gomatrixserverlib.Join, 10) if err != nil { t.Fatalf("failed to get membership count: %s", err) @@ -176,6 +174,7 @@ func testUpsert(t *testing.T, ctx context.Context, table tables.Memberships, mem t.Fatalf("failed to upsert membership: %s", err) } + // Verify the position got updated membership, pos, err = table.SelectMembershipForUser(ctx, nil, room.ID, user.ID, 10) if err != nil { t.Fatalf("failed to select membership: %s", err)