From c2c0db3f377b56e067bf31d9707b973dac7fe13d Mon Sep 17 00:00:00 2001 From: Neil Alexander Date: Tue, 11 Aug 2020 12:15:28 +0100 Subject: [PATCH] Review comments @Kegsay --- dendrite-config.yaml | 9 +++++++-- internal/config/config_kafka.go | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dendrite-config.yaml b/dendrite-config.yaml index 6913a40c0..74bb0711b 100644 --- a/dendrite-config.yaml +++ b/dendrite-config.yaml @@ -17,6 +17,9 @@ # SQLite is embedded into Dendrite and therefore no further prerequisites are # needed for the database when using SQLite mode. However, performance with # PostgreSQL is significantly better and recommended for multi-user deployments. +# SQLite is typically around 20-30% slower than PostgreSQL when tested with a +# small number of users and likely will perform worse still with a higher volume +# of users. # # The "max_open_conns" and "max_idle_conns" settings configure the maximum # number of open/idle database connections. The value 0 will use the database @@ -52,8 +55,10 @@ global: # Configuration for Kafka/Naffka. kafka: - # List of Kafka addresses to connect to. This is not needed if using Naffka. - addresses: [] + # List of Kafka broker addresses to connect to. This is not needed if using + # Naffka in monolith mode. + addresses: + - localhost:2181 # The prefix to use for Kafka topic names for this homeserver. Change this only if # you are running more than one Dendrite homeserver on the same Kafka deployment. diff --git a/internal/config/config_kafka.go b/internal/config/config_kafka.go index 443995006..e2bd6538e 100644 --- a/internal/config/config_kafka.go +++ b/internal/config/config_kafka.go @@ -33,6 +33,7 @@ func (k *Kafka) TopicFor(name string) string { func (c *Kafka) Defaults() { c.UseNaffka = true c.Database.Defaults() + c.Addresses = []string{"localhost:2181"} c.Database.ConnectionString = DataSource("file:naffka.db") c.TopicPrefix = "Dendrite" }