From c5d5c36e7d7f2e514865bc601d85e01e48425640 Mon Sep 17 00:00:00 2001 From: Till Faelligen Date: Fri, 8 Apr 2022 18:26:58 +0200 Subject: [PATCH] PR comments --- syncapi/routing/context.go | 4 +--- syncapi/streams/stream_pdu.go | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/syncapi/routing/context.go b/syncapi/routing/context.go index d2858c52f..aaa0c61bf 100644 --- a/syncapi/routing/context.go +++ b/syncapi/routing/context.go @@ -61,9 +61,7 @@ func Context( } } if filter.Rooms != nil { - roomsFilter := *filter.Rooms - roomsFilter = append(roomsFilter, roomID) - filter.Rooms = &roomsFilter + *filter.Rooms = append(*filter.Rooms, roomID) } ctx := req.Context() diff --git a/syncapi/streams/stream_pdu.go b/syncapi/streams/stream_pdu.go index e6fe393b5..bcaf6ca31 100644 --- a/syncapi/streams/stream_pdu.go +++ b/syncapi/streams/stream_pdu.go @@ -423,7 +423,7 @@ func (p *PDUStreamProvider) addIgnoredUsersToFilter(ctx context.Context, req *ty return err } req.IgnoredUsers = *ignores - var userList []string = nil + userList := make([]string, 0, len(ignores.List)) for userID := range ignores.List { userList = append(userList, userID) }