move the call to validatePassword into the switch statement

This commit is contained in:
Devon Mizelle 2021-09-29 19:46:08 -04:00
parent eadbfa7eea
commit c6984b2020

View file

@ -232,7 +232,7 @@ func validatePassword(password string, cfg config.PasswordRequirements) *util.JS
Code: http.StatusBadRequest, Code: http.StatusBadRequest,
JSON: jsonerror.WeakPassword(fmt.Sprintf("'password' >%d characters", cfg.MaxPasswordLength)), JSON: jsonerror.WeakPassword(fmt.Sprintf("'password' >%d characters", cfg.MaxPasswordLength)),
} }
} else if len(password) >= 0 && len(password) < cfg.MinPasswordLength { } else if len(password) > 0 && len(password) < cfg.MinPasswordLength {
return &util.JSONResponse{ return &util.JSONResponse{
Code: http.StatusBadRequest, Code: http.StatusBadRequest,
JSON: jsonerror.WeakPassword(fmt.Sprintf("password too weak: min %d chars", cfg.MinPasswordLength)), JSON: jsonerror.WeakPassword(fmt.Sprintf("password too weak: min %d chars", cfg.MinPasswordLength)),
@ -541,9 +541,9 @@ func Register(
if resErr = validateUsername(r.Username); resErr != nil { if resErr = validateUsername(r.Username); resErr != nil {
return *resErr return *resErr
} }
} if resErr = validatePassword(r.Password, cfg.PasswordRequirements); resErr != nil {
if resErr = validatePassword(r.Password, cfg.PasswordRequirements); resErr != nil { return *resErr
return *resErr }
} }
logger := util.GetLogger(req.Context()) logger := util.GetLogger(req.Context())