mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-01 03:03:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Reduce allocations on presence

Browse source
This commit is contained in:
Neil Alexander 2022-04-06 12:23:20 +01:00
parent e5e3350ce1
commit ca73cf09b3
No known key found for this signature in database
GPG key ID: A02A2019A2BB0944
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
syncapi/notifier/notifier.go
View file

@ -509,6 +509,7 @@ func (s userIDSet) remove(str string) {
} }
func (s userIDSet) values() (vals []string) { func (s userIDSet) values() (vals []string) {
vals = make([]string, 0, len(s))
for str := range s { for str := range s {
vals = append(vals, str) vals = append(vals, str)
} }
@ -529,6 +530,7 @@ func (s peekingDeviceSet) remove(d types.PeekingDevice) {
} }
func (s peekingDeviceSet) values() (vals []types.PeekingDevice) { func (s peekingDeviceSet) values() (vals []types.PeekingDevice) {
vals = make([]types.PeekingDevice, 0, len(s))
for d := range s { for d := range s {
vals = append(vals, d) vals = append(vals, d)
} }

5
syncapi/streams/stream_presence.go
View file

@ -68,10 +68,9 @@ func (p *PresenceStreamProvider) IncrementalSync(
// TODO: SharedUsers might get out of sync // TODO: SharedUsers might get out of sync
sharedUsers := p.notifier.SharedUsers(req.Device.UserID) sharedUsers := p.notifier.SharedUsers(req.Device.UserID)
sharedUsersMap := map[string]bool{
req.Device.UserID: true,
}
// convert array to a map for easier checking if a user exists // convert array to a map for easier checking if a user exists
sharedUsersMap := make(map[string]bool, len(sharedUsers))
sharedUsersMap[req.Device.UserID] = true
for i := range sharedUsers { for i := range sharedUsers {
sharedUsersMap[sharedUsers[i]] = true sharedUsersMap[sharedUsers[i]] = true
} }