From cb4aab0fa0d735b6eadee97b59a99336ee434de2 Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Fri, 9 Dec 2022 17:49:28 +0100
Subject: [PATCH] Add some invalid joins

---
 clientapi/routing/joinroom_test.go | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/clientapi/routing/joinroom_test.go b/clientapi/routing/joinroom_test.go
index b9cb2e513..38df47187 100644
--- a/clientapi/routing/joinroom_test.go
+++ b/clientapi/routing/joinroom_test.go
@@ -91,5 +91,23 @@ func TestJoinRoomByIDOrAlias(t *testing.T) {
 			t.Fatalf("expected response code to be %d, got %d", http.StatusForbidden, joinResp.Code)
 		}
 
+		// Some invalid requests
+		// room doesn't exist
+		joinResp = JoinRoomByIDOrAlias(req, aliceDev, rsAPI, userAPI, "!doesnotexist:test")
+		if joinResp.Is2xx() {
+			t.Fatalf("expected join room to fail, but didn't: %+v", joinResp)
+		}
+
+		// user from different server
+		joinResp = JoinRoomByIDOrAlias(req, &uapi.Device{UserID: "@wrong:server"}, rsAPI, userAPI, crResp.RoomAlias)
+		if joinResp.Is2xx() {
+			t.Fatalf("expected join room to fail, but didn't: %+v", joinResp)
+		}
+
+		// user doesn't exist locally
+		joinResp = JoinRoomByIDOrAlias(req, &uapi.Device{UserID: "@doesnotexist:test"}, rsAPI, userAPI, crResp.RoomAlias)
+		if joinResp.Is2xx() {
+			t.Fatalf("expected join room to fail, but didn't: %+v", joinResp)
+		}
 	})
 }