mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2024-11-26 00:01:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #97 from matrix-org/rob/util-logging-context-fix

Browse source 
Update github.com/matrix-org/util for request context fix for logging
This commit is contained in:
Robert Swain 2017-05-10 15:56:49 +02:00 committed by GitHub
parent 04f3c154b8 042d636e34
commit cdd2617f8e
2 changed files with 23 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
vendor/manifest vendored
View file

@ -98,7 +98,7 @@
{
"importpath": "github.com/matrix-org/util",
"repository": "https://github.com/matrix-org/util",
"revision": "bc9d5e2d2f68a2ca279fce0fa2f28a91ecf301ed",
"revision": "53326ed5598b226681112cbd441f59f3cffc9c82",
"branch": "master"
},
{

17
vendor/src/github.com/matrix-org/util/json.go vendored
View file

@ -93,11 +93,10 @@ func Protect(handler http.HandlerFunc) http.HandlerFunc {
}
}
// MakeJSONAPI creates an HTTP handler which always responds to incoming requests with JSON responses.
// Incoming http.Requests will have a logger (with a request ID/method/path logged) attached to the Context.
// RequestWithLogging sets up standard logging for http.Requests.
// http.Requests will have a logger (with a request ID/method/path logged) attached to the Context.
// This can be accessed via GetLogger(Context).
func MakeJSONAPI(handler JSONRequestHandler) http.HandlerFunc {
return Protect(func(w http.ResponseWriter, req *http.Request) {
func RequestWithLogging(req *http.Request) *http.Request {
reqID := RandomString(12)
// Set a Logger and request ID on the context
ctx := context.WithValue(req.Context(), ctxValueLogger, log.WithFields(log.Fields{
@ -111,6 +110,16 @@ func MakeJSONAPI(handler JSONRequestHandler) http.HandlerFunc {
logger := GetLogger(req.Context())
logger.Print("Incoming request")
return req
}
// MakeJSONAPI creates an HTTP handler which always responds to incoming requests with JSON responses.
// Incoming http.Requests will have a logger (with a request ID/method/path logged) attached to the Context.
// This can be accessed via GetLogger(Context).
func MakeJSONAPI(handler JSONRequestHandler) http.HandlerFunc {
return Protect(func(w http.ResponseWriter, req *http.Request) {
req = RequestWithLogging(req)
if req.Method == "OPTIONS" {
SetCORSHeaders(w)
w.WriteHeader(200)