From d4db450f146e57d09106d8406f46bc328ca75792 Mon Sep 17 00:00:00 2001 From: Neil Alexander Date: Tue, 26 May 2020 16:41:13 +0100 Subject: [PATCH] Return error if we failed to fetch some keys --- serverkeyapi/internal/api.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/serverkeyapi/internal/api.go b/serverkeyapi/internal/api.go index ebba62b34..d560333ce 100644 --- a/serverkeyapi/internal/api.go +++ b/serverkeyapi/internal/api.go @@ -2,6 +2,7 @@ package internal import ( "context" + "fmt" "github.com/matrix-org/dendrite/internal/caching" "github.com/matrix-org/dendrite/internal/config" @@ -64,6 +65,10 @@ func (s *ServerKeyAPI) FetchKeys( } } } + // If we failed to fetch any keys then we should report an error. + if len(requests) > 0 { + return nil, fmt.Errorf("server key API failed to fetch %d keys", len(requests)) + } // Return the keys. return results, nil }