From d6011fb4d465e7868077b94cc218b60d6629b053 Mon Sep 17 00:00:00 2001 From: Priydarshi Singh Date: Wed, 1 Jan 2020 00:46:47 +0530 Subject: [PATCH] Return 400 M_NOT_JSON for empty request body in /rooms/:roomID/:action Fixes #767 Signed-off-by: Priydarshi Singh dryairship@gmail.com --- clientapi/routing/membership.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/clientapi/routing/membership.go b/clientapi/routing/membership.go index c71ac2de2..df6e9cb6f 100644 --- a/clientapi/routing/membership.go +++ b/clientapi/routing/membership.go @@ -46,6 +46,14 @@ func SendMembership( producer *producers.RoomserverProducer, ) util.JSONResponse { var body threepid.MembershipRequest + + if req.Body == http.NoBody { + return util.JSONResponse{ + Code: http.StatusBadRequest, + JSON: jsonerror.NotJSON("No request body"), + } + } + if reqErr := httputil.UnmarshalJSONRequest(req, &body); reqErr != nil { return *reqErr }