From a684b850b9dccc12121c6ff314c1ecd660f8c9a2 Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Mon, 6 Mar 2023 17:45:21 +0100
Subject: [PATCH 1/3] Actually ignore the error if we were able to backfill
 events

---
 roomserver/internal/perform/perform_backfill.go | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/roomserver/internal/perform/perform_backfill.go b/roomserver/internal/perform/perform_backfill.go
index 07ad28b82..4e2dbbea2 100644
--- a/roomserver/internal/perform/perform_backfill.go
+++ b/roomserver/internal/perform/perform_backfill.go
@@ -133,9 +133,6 @@ func (r *Backfiller) backfillViaFederation(ctx context.Context, req *api.Perform
 
 	// persist these new events - auth checks have already been done
 	roomNID, backfilledEventMap := persistEvents(ctx, r.DB, events)
-	if err != nil {
-		return err
-	}
 
 	for _, ev := range backfilledEventMap {
 		// now add state for these events

From 11a3fcc6cbaa7368b4360ba5cd88e48633a31da0 Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Mon, 6 Mar 2023 17:58:08 +0100
Subject: [PATCH 2/3] RoomServerEvents are mutable, given they can be redacted

---
 internal/caching/impl_ristretto.go | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/internal/caching/impl_ristretto.go b/internal/caching/impl_ristretto.go
index fca93afd1..106b9c99f 100644
--- a/internal/caching/impl_ristretto.go
+++ b/internal/caching/impl_ristretto.go
@@ -22,11 +22,12 @@ import (
 
 	"github.com/dgraph-io/ristretto"
 	"github.com/dgraph-io/ristretto/z"
-	"github.com/matrix-org/dendrite/roomserver/types"
-	"github.com/matrix-org/dendrite/setup/config"
 	"github.com/matrix-org/gomatrixserverlib"
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promauto"
+
+	"github.com/matrix-org/dendrite/roomserver/types"
+	"github.com/matrix-org/dendrite/setup/config"
 )
 
 const (
@@ -98,9 +99,10 @@ func NewRistrettoCache(maxCost config.DataUnit, maxAge time.Duration, enableProm
 		},
 		RoomServerEvents: &RistrettoCostedCachePartition[int64, *gomatrixserverlib.Event]{ // event NID -> event
 			&RistrettoCachePartition[int64, *gomatrixserverlib.Event]{
-				cache:  cache,
-				Prefix: roomEventsCache,
-				MaxAge: maxAge,
+				cache:   cache,
+				Prefix:  roomEventsCache,
+				MaxAge:  maxAge,
+				Mutable: true,
 			},
 		},
 		RoomServerStateKeys: &RistrettoCachePartition[types.EventStateKeyNID, string]{ // event NID -> event state key

From baef523cb02f7164ec25a5fcf513a042c5428f01 Mon Sep 17 00:00:00 2001
From: Till Faelligen <2353100+S7evinK@users.noreply.github.com>
Date: Tue, 7 Mar 2023 15:35:08 +0100
Subject: [PATCH 3/3] Fix invalid roomNID returned

---
 roomserver/internal/perform/perform_backfill.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/roomserver/internal/perform/perform_backfill.go b/roomserver/internal/perform/perform_backfill.go
index 4e2dbbea2..23862b242 100644
--- a/roomserver/internal/perform/perform_backfill.go
+++ b/roomserver/internal/perform/perform_backfill.go
@@ -608,6 +608,7 @@ func persistEvents(ctx context.Context, db storage.Database, events []*gomatrixs
 			logrus.WithError(err).Error("failed to get or create roomNID")
 			continue
 		}
+		roomNID = roomInfo.RoomNID
 
 		eventTypeNID, err := db.GetOrCreateEventTypeNID(ctx, ev.Type())
 		if err != nil {