mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-16 18:43:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix issue where newly joined room state is not returned to the client

Browse source
This commit is contained in:
Tak Wai Wong 2022-10-28 12:58:28 -07:00
parent 69aff372f3
commit e5ae13f541
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
syncapi/streams/stream_pdu.go
View file

@ -252,7 +252,13 @@ func (p *PDUStreamProvider) addRoomDeltaToResponse(
return r.From, fmt.Errorf("p.DB.RecentEvents: %w", err) return r.From, fmt.Errorf("p.DB.RecentEvents: %w", err)
} }
recentEvents := snapshot.StreamEventsToEvents(device, recentStreamEvents) recentEvents := snapshot.StreamEventsToEvents(device, recentStreamEvents)
delta.StateEvents = removeDuplicates(delta.StateEvents, recentEvents) // roll back // Don't remove the state events if this is a newly joined room. The member
// needs the full room state. For example, to figure out if the room is a space
// or not, it needs the m.room.create event which may be chronologically outside
// the filter limit.
if !delta.NewlyJoined {
delta.StateEvents = removeDuplicates(delta.StateEvents, recentEvents) // roll back
}
prevBatch, err := snapshot.GetBackwardTopologyPos(ctx, recentStreamEvents) prevBatch, err := snapshot.GetBackwardTopologyPos(ctx, recentStreamEvents)
if err != nil { if err != nil {
return r.From, fmt.Errorf("p.DB.GetBackwardTopologyPos: %w", err) return r.From, fmt.Errorf("p.DB.GetBackwardTopologyPos: %w", err)