mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-15 10:03:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Update changelog

Browse source
This commit is contained in:
Till Faelligen 2023-07-06 08:50:37 +02:00
parent 679817ffb3
commit e64936765a
No known key found for this signature in database
GPG key ID: ACCDC9606D472758
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
CHANGES.md
View file

@ -4,10 +4,11 @@
This releases fixes a long-standing "off-by-one" error which could result in state resets. Upgrading to this version is **highly** recommended. This releases fixes a long-standing "off-by-one" error which could result in state resets. Upgrading to this version is **highly** recommended.
When storing state events, we were checking if the event in question was already in something we call a "state snapshot". If it was in a previous state snapshot, we would When deduplicating state events, we were checking if the event in question was already in a state snapshot. If it was in a previous state snapshot, we would
then remove it from the list of events to store. If this happened, we were, unfortunately, skipping the next event to check. This resulted in then remove it from the list of events to store. If this happened, we were, unfortunately, skipping the next event to check. This resulted in
events getting stored in state snapshots where they may not be needed. When we now compared two of those state snapshots, one of them events getting stored in state snapshots where they may not be needed. When we now compared two of those state snapshots, one of them
contained the skipped event, while the other didn't. So there was a difference between them which possibly shouldn't exist, resulting in unexpected state resets. contained the skipped event, while the other didn't. This difference possibly shouldn't exist, resulting in unexpected state resets.
This also explains reports of rooms missing state events.
This has been fixed - rooms where a state reset occurred earlier should, hopefully, reconcile over time. This has been fixed - rooms where a state reset occurred earlier should, hopefully, reconcile over time.