mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2024-11-22 14:21:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential connection leak (#3247)

Browse source 
We didn't rollback/commit after getting events, now we're rolling back
since we didn't change anything.
This commit is contained in:
Till 2023-11-08 14:22:20 +01:00 committed by GitHub
parent 5f872f4a82
commit ee73a90aea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
syncapi/routing/getevent.go
View file

@ -44,7 +44,7 @@ func GetEvent(
rsAPI api.SyncRoomserverAPI, rsAPI api.SyncRoomserverAPI,
) util.JSONResponse { ) util.JSONResponse {
ctx := req.Context() ctx := req.Context()
db, err := syncDB.NewDatabaseTransaction(ctx) db, err := syncDB.NewDatabaseSnapshot(ctx)
logger := util.GetLogger(ctx).WithFields(logrus.Fields{ logger := util.GetLogger(ctx).WithFields(logrus.Fields{
"event_id": eventID, "event_id": eventID,
"room_id": rawRoomID, "room_id": rawRoomID,
@ -56,6 +56,7 @@ func GetEvent(
JSON: spec.InternalServerError{}, JSON: spec.InternalServerError{},
} }
} }
defer db.Rollback() // nolint: errcheck
roomID, err := spec.NewRoomID(rawRoomID) roomID, err := spec.NewRoomID(rawRoomID)
if err != nil { if err != nil {