mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2026-01-01 03:03:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

Check that the send event is actually an m.room.canonical_alias

Browse source 
Check that we got an event from the database
This commit is contained in:
Till Faelligen 2022-03-04 10:44:04 +01:00
parent 6dbf96ed75
commit f2e0a652b2
2 changed files with 39 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clientapi/routing/sendevent.go
View file

@ -123,7 +123,7 @@ func SendEvent(
timeToGenerateEvent := time.Since(startedGeneratingEvent)
// validate that the aliases exists
if eventType == gomatrixserverlib.MRoomCanonicalAlias {
if eventType == gomatrixserverlib.MRoomCanonicalAlias && stateKey != nil && *stateKey == "" {
aliasReq := api.AliasEvent{}
if err = json.Unmarshal(e.Content(), &aliasReq); err != nil {
return util.ErrorResponse(fmt.Errorf("unable to parse alias event: %w", err))

42
roomserver/internal/alias.go
View file

@ -22,6 +22,7 @@ import (
asAPI "github.com/matrix-org/dendrite/appservice/api"
"github.com/matrix-org/dendrite/roomserver/api"
"github.com/matrix-org/dendrite/roomserver/internal/helpers"
"github.com/matrix-org/gomatrixserverlib"
"github.com/tidwall/gjson"
"github.com/tidwall/sjson"
@ -189,8 +190,7 @@ func (r *RoomserverInternalAPI) RemoveRoomAlias(
ev, err := r.DB.GetStateEvent(ctx, roomID, gomatrixserverlib.MRoomCanonicalAlias, "")
if err != nil && err != sql.ErrNoRows {
return err
}
} else if ev != nil {
stateAlias := gjson.GetBytes(ev.Content(), "alias").Str
// the alias to remove is currently set as the canonical alias, remove it
if stateAlias == request.Alias {
@ -199,28 +199,28 @@ func (r *RoomserverInternalAPI) RemoveRoomAlias(
return err
}
stateRes := &api.QueryLatestEventsAndStateResponse{}
if err = r.QueryLatestEventsAndState(ctx, &api.QueryLatestEventsAndStateRequest{RoomID: roomID}, stateRes); err != nil {
return err
}
stateEventIDs := make([]string, len(stateRes.StateEvents))
for i, ev := range stateRes.StateEvents {
stateEventIDs[i] = ev.EventID()
}
sender := request.UserID
if request.UserID != ev.Sender() {
sender = ev.Sender()
}
stateRes := &api.QueryLatestEventsAndStateResponse{}
if err := helpers.QueryLatestEventsAndState(ctx, r.DB, &api.QueryLatestEventsAndStateRequest{RoomID: roomID}, stateRes); err != nil {
return err
}
authEvents := make([]string, len(stateRes.StateEvents))
for i := range stateRes.StateEvents {
authEvents[i] = stateRes.StateEvents[i].EventID()
}
builder := &gomatrixserverlib.EventBuilder{
Sender: sender,
RoomID: ev.RoomID(),
Type: ev.Type(),
StateKey: ev.StateKey(),
PrevEvents: []string{ev.EventID()},
AuthEvents: stateEventIDs,
AuthEvents: authEvents,
Content: res,
}
@ -229,19 +229,11 @@ func (r *RoomserverInternalAPI) RemoveRoomAlias(
return err
}
inputEvent := api.InputRoomEvent{
Kind: api.KindNew,
Event: newEvent.Headered(ev.RoomVersion),
Origin: r.ServerName,
StateEventIDs: stateEventIDs,
HasState: true,
SendAsServer: string(r.ServerName),
err = api.SendEvents(ctx, r.RSAPI, api.KindNew, []*gomatrixserverlib.HeaderedEvent{newEvent.Headered(ev.RoomVersion)}, r.ServerName, r.ServerName, nil, false)
if err != nil {
return err
}
respInput := &api.InputRoomEventsResponse{}
r.InputRoomEvents(ctx, &api.InputRoomEventsRequest{InputRoomEvents: []api.InputRoomEvent{inputEvent}}, respInput)
if respInput.NotAllowed || respInput.ErrMsg != "" {
return fmt.Errorf(respInput.ErrMsg)
}
}