From f58ee67a7a4bc661958feb258ef04e9c44ee3f86 Mon Sep 17 00:00:00 2001
From: Neil Alexander <neilalexander@users.noreply.github.com>
Date: Wed, 2 Feb 2022 15:42:22 +0000
Subject: [PATCH] Fix bugs

---
 roomserver/internal/input/input.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/roomserver/internal/input/input.go b/roomserver/internal/input/input.go
index 80614bc52..ea7bf8480 100644
--- a/roomserver/internal/input/input.go
+++ b/roomserver/internal/input/input.go
@@ -157,18 +157,15 @@ func (r *Inputer) processRoomEventUsingUpdater(
 	}
 	commit, err := r.processRoomEvent(ctx, updater, inputRoomEvent)
 	if commit {
-		if err = updater.Commit(); err != nil {
-			return false, fmt.Errorf("updater.Commit: %w", err)
+		if cerr := updater.Commit(); err != nil {
+			return true, fmt.Errorf("updater.Commit: %w", cerr)
 		}
 	} else {
 		if rerr := updater.Rollback(); rerr != nil {
-			return true, fmt.Errorf("updater.Rollback: %w", err)
+			return true, fmt.Errorf("updater.Rollback: %w", rerr)
 		}
 	}
-	if err != nil {
-		return true, err
-	}
-	return false, nil
+	return false, err
 }
 
 // InputRoomEvents implements api.RoomserverInternalAPI