mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-13 01:43:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix off by one error

Browse source
This commit is contained in:
Erik Johnston 2017-10-18 11:02:38 +01:00
parent 11251c9762
commit fd61776f93
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/github.com/matrix-org/dendrite/syncapi/sync/userstream.go
View file

@ -77,7 +77,7 @@ func (s *UserStream) Wait(ctx context.Context, waitAtPos types.StreamPosition) <
// Icky but efficient way of filtering out the given channel // Icky but efficient way of filtering out the given channel
for idx, ch := range s.waitingChannels { for idx, ch := range s.waitingChannels {
if posChannel == ch { if posChannel == ch {
lastIdx := len(s.waitingChannels) lastIdx := len(s.waitingChannels) - 1
s.waitingChannels[idx] = s.waitingChannels[lastIdx] s.waitingChannels[idx] = s.waitingChannels[lastIdx]
s.waitingChannels[lastIdx] = nil // Ensure that the channel gets GCed s.waitingChannels[lastIdx] = nil // Ensure that the channel gets GCed
s.waitingChannels = s.waitingChannels[:lastIdx] s.waitingChannels = s.waitingChannels[:lastIdx]