mirrors/dendrite
1
0
Fork 0
mirror of https://github.com/matrix-org/dendrite.git synced 2025-12-26 00:03:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

syncapi/requestpool: reintroduce req.since == nil check

Browse source
This commit is contained in:
Ariadne Conill 2020-11-22 13:13:12 +00:00
parent 16e3156260
commit ff787ccd7e
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
syncapi/sync/requestpool.go
View file

@ -328,9 +328,7 @@ func (rp *RequestPool) appendAccountData(
// data keys were set between two message. This isn't a huge issue since the // data keys were set between two message. This isn't a huge issue since the
// duplicate data doesn't represent a huge quantity of data, but an optimisation // duplicate data doesn't represent a huge quantity of data, but an optimisation
// here would be making sure each data is sent only once to the client. // here would be making sure each data is sent only once to the client.
// TODO: We used to have req.since == nil here, is there any case where req.since if req.since == nil || (req.since.PDUPosition() == 0 && req.since.EDUPosition() == 0) {
// can actually be nil?
if req.since.PDUPosition() == 0 && req.since.EDUPosition() == 0 {
// If this is the initial sync, we don't need to check if a data has // If this is the initial sync, we don't need to check if a data has
// already been sent. Instead, we send the whole batch. // already been sent. Instead, we send the whole batch.
dataReq := &userapi.QueryAccountDataRequest{ dataReq := &userapi.QueryAccountDataRequest{