dendrite

635 commits 57 branches 102 tags 160 MiB

Author	SHA1	Message	Date
Kiril Vladimiroff	59465746bc	Always defer *sql.Rows.Close and consult with Err database/sql.Rows.Next() makes sure to call Close only after exhausting result rows which would NOT happen when returning early from a bad Scan. Close being idempotent makes it a great candidate to get always deferred regardless of what happens later on the result set. This change also makes sure call Err() after exhausting Next() and propagate non-nil results from it as the documentation advises. Closes #764 Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>	2020-02-06 11:27:24 +02:00
ruben	74827428bd	use go module for dependencies (#594 )	2019-05-21 21:56:55 +01:00

Author

SHA1

Message

Date

Kiril Vladimiroff

59465746bc

Always defer *sql.Rows.Close and consult with Err

database/sql.Rows.Next() makes sure to call Close only after exhausting
result rows which would NOT happen when returning early from a bad Scan.
Close being idempotent makes it a great candidate to get always deferred
regardless of what happens later on the result set.

This change also makes sure call Err() after exhausting Next() and
propagate non-nil results from it as the documentation advises.

Closes #764

Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>

2020-02-06 11:27:24 +02:00

ruben

74827428bd

use go module for dependencies (#594 )

2019-05-21 21:56:55 +01:00

Renamed from src/github.com/matrix-org/dendrite/clientapi/auth/storage/accounts/membership_table.go (Browse further)

2 commits